Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDispatchFromFlagsAndUseBuiltInArgs fails on arm #263

Closed
siretart opened this issue Sep 4, 2023 · 4 comments · Fixed by #272
Closed

TestDispatchFromFlagsAndUseBuiltInArgs fails on arm #263

siretart opened this issue Sep 4, 2023 · 4 comments · Fixed by #272

Comments

@siretart
Copy link

siretart commented Sep 4, 2023

#224 introduces a test that fail on arm64, armhf and armel with:

On arm64:

=== RUN   TestDispatchFromFlagsAndUseBuiltInArgs
    dispatchers_test.go:798: Expected linux/arm64, to match linux/arm64/v8
--- FAIL: TestDispatchFromFlagsAndUseBuiltInArgs (0.00s)

on armel:

=== RUN   TestDispatchFromFlagsAndUseBuiltInArgs
    dispatchers_test.go:798: Expected linux/arm, to match linux/arm/v8
--- FAIL: TestDispatchFromFlagsAndUseBuiltInArgs (0.00s)

On armhf:

=== RUN   TestDispatchFromFlagsAndUseBuiltInArgs
    dispatchers_test.go:798: Expected linux/arm, to match linux/arm/v7
--- FAIL: TestDispatchFromFlagsAndUseBuiltInArgs (0.00s)
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 4, 2023
@siretart
Copy link
Author

siretart commented Dec 5, 2023

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2023
@rhatdan
Copy link
Contributor

rhatdan commented Dec 5, 2023

@flouthoc @nalind PTAL

@nalind
Copy link
Member

nalind commented Dec 5, 2023

I don't have easy access to most of the affected platforms, but #272 at least does the right thing in my aarch64 VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants