New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to remove all failover configurations. #98
Add a script to remove all failover configurations. #98
Conversation
fi | ||
|
||
cleanup $(pidof /usr/sbin/keepalived) | ||
service keepalived stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That takes me back! Any reason not to use systemctl? Last time I used the service command (which was years ago, on RHEL7), it worked, but it printed some extra noise encouraging using systemctl instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since cleanup function is will kill keepalived and exit there is no need to systemctl or remove the config file so I will remove those two lines
|
||
cleanup $(pidof /usr/sbin/keepalived) | ||
service keepalived stop | ||
[ -f "$KEEPALIVED_CONFIG" ] && rm -f "$KEEPALIVED_CONFIG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ambivalent about removing the config file, but in any case, keepalived-ipfailover is intended to be run inside a container, so is it really useful to clean up the config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove it
2f4fa35
to
6d9f194
Compare
dcc22b9
to
d34dff9
Compare
/retest |
1ed5c5d
to
db78f0b
Compare
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
fa1fe3d
to
1ecb85a
Compare
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com
In order to allow existing customers who are using OpenShift failover feature to different HA implementations, we need to remove all fail over configurations