Fix TestArchiveContains/File: Check if insights operator records an event #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psimovec
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
psimovec
changed the title
psimovec
force-pushed
the
fixtestarchivecontains
branch
from
a34cbf1
to
51317fe
Compare
|
/retest |
psimovec
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
psimovec
force-pushed
the
fixtestarchivecontains
branch
from
51317fe
to
dcf1e3c
Compare
martinkunc
reviewed
Aug 12, 2020
test/integration/main_test.go
Outdated
| @@ -184,12 +184,13 @@ func deleteAllPods(t *testing.T, namespace string) { | |||
| } | |||
|
|
|||
| func checkPodsLogs(t *testing.T, kubeClient *kubernetes.Clientset, message string, newLogsOnly ...bool) { | |||
| timeNow := metav1.NewTime(time.Now()) | |||
| timeNow.Add(-2*time.Second) | |||
There was a problem hiding this comment.
If we use newLogsOnly=false, it could be safer then rely on (arbitrary) time before Now
There was a problem hiding this comment.
This would cause problems and probably break the tests even more. If I use newLogsOnly=false, then it’s almost certain that that the check for .*Wrote \d+ records to disk in \d+ will pass immediately, as it will be in logs already.. so tests of Logs and Event will get old archive again and fail. But I agree that it’s not the best solution now, I will try to find a different one.
psimovec
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
psimovec
force-pushed
the
fixtestarchivecontains
branch
from
dcf1e3c
to
ec5452c
Compare
psimovec
force-pushed
the
fixtestarchivecontains
branch
from
ec5452c
to
5a8092c
Compare
psimovec
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkunc, psimovec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if insights operator records an event file before checking that the records were written to the disk should prevent running tests with an older archive that doesn't have new records yet