Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880352: collect hostsubnet information #180

Merged
merged 1 commit into from Oct 1, 2020
Merged

Bug 1880352: collect hostsubnet information #180

merged 1 commit into from Oct 1, 2020

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Sep 18, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1880352, which is invalid:

  • expected dependent Bugzilla bug 1879068 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[releset-4.5] Bug 1880352: collect hostsubnet information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes closed this Sep 18, 2020
@tremes tremes reopened this Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1880352, which is invalid:

  • expected dependent Bugzilla bug 1879068 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[releset-4.5] Bug 1880352: collect hostsubnet information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes changed the title [releset-4.5] Bug 1880352: collect hostsubnet information [release-4.5] Bug 1880352: collect hostsubnet information Sep 18, 2020
@tremes
Copy link
Contributor Author

tremes commented Sep 21, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1880352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1879068 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1879068 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2020
natiiix
natiiix approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Haven't really tested it locally, but the gathering code and the test seem fine.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@tremes
Copy link
Contributor Author

tremes commented Sep 21, 2020

/retest

@tremes tremes requested a review from natiiix September 21, 2020 13:13
@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2020

/retest

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2020

/retest

@martinkunc
Copy link
Contributor

Thank you @tremes , it looks great.

One small detail, could you please run make gen-doc and add update of generated docs/gathered-data.md and if you have add also example of generated .json files to the archive in docs/insights-archive-sample

@tremes
Copy link
Contributor Author

tremes commented Sep 23, 2020

/retest

@tremes
Copy link
Contributor Author

tremes commented Sep 23, 2020

/test e2e-aws

@tremes
Copy link
Contributor Author

tremes commented Sep 24, 2020

/test e2e-aws

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Sep 24, 2020

/test e2e-aws

@tremes
Copy link
Contributor Author

tremes commented Sep 24, 2020

/retest

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Sep 28, 2020

/retest

natiiix
natiiix approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow
Copy link
Member

ashcrow commented Oct 1, 2020

Backport of #177

@ashcrow
Copy link
Member

ashcrow commented Oct 1, 2020

/retitle Bug 1880352: collect hostsubnet information

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1880352: collect hostsubnet information Bug 1880352: collect hostsubnet information Oct 1, 2020
@ashcrow ashcrow added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 1, 2020
@tremes
Copy link
Contributor Author

tremes commented Oct 1, 2020

Thanks for the label @ashcrow

@openshift-merge-robot openshift-merge-robot merged commit d26a96d into openshift:release-4.5 Oct 1, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1880352 has been moved to the MODIFIED state.

In response to this:

Bug 1880352: collect hostsubnet information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes deleted the hostsubnet_4.5 branch September 14, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natiiix natiiix natiiix approved these changes

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@natiiix natiiix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tremes @openshift-ci-robot @martinkunc @ashcrow @natiiix @openshift-merge-robot