Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1882858: Automate TestArchiveContains::HostsSubnet & 2 more #182

Merged
merged 1 commit into from Sep 28, 2020
Merged

Bug 1882858: Automate TestArchiveContains::HostsSubnet & 2 more #182

merged 1 commit into from Sep 28, 2020

Conversation

psimovec
Copy link
Member

@psimovec psimovec commented Sep 18, 2020 •
edited

@psimovec psimovec force-pushed the hostsubnet_files_in_archive branch 2 times, most recently from 2dae116 to c6dadaf Compare September 18, 2020 17:07
tisnik
tisnik approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@psimovec psimovec changed the title Automate TestArchiveContains::HostsSubnet Bug 1879068: Automate TestArchiveContains::HostsSubnet Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@psimovec: This pull request references Bugzilla bug 1879068, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1879068: Automate TestArchiveContains::HostsSubnet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 25, 2020
@psimovec psimovec changed the title Bug 1879068: Automate TestArchiveContains::HostsSubnet Automate TestArchiveContains::HostsSubnet Sep 25, 2020
@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@psimovec: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Automate TestArchiveContains::HostsSubnet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@psimovec psimovec changed the title Automate TestArchiveContains::HostsSubnet Automate TestArchiveContains::HostsSubnet & 2 more Sep 25, 2020
@psimovec psimovec changed the title Automate TestArchiveContains::HostsSubnet & 2 more Bug 1882858: Automate TestArchiveContains::HostsSubnet & 2 more Sep 25, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@psimovec: This pull request references Bugzilla bug 1882858, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882858: Automate TestArchiveContains::HostsSubnet & 2 more

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rluders
Copy link
Contributor

rluders commented Sep 28, 2020

Just looking into the code and it seems fine.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psimovec, rluders, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [psimovec,rluders,tisnik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 00d2844 into openshift:master Sep 28, 2020
@openshift-ci-robot
Copy link
Contributor

@psimovec: All pull requests linked via external trackers have merged:

Bugzilla bug 1882858 has been moved to the MODIFIED state.

In response to this:

Bug 1882858: Automate TestArchiveContains::HostsSubnet & 2 more

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisnik tisnik tisnik approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@psimovec @openshift-ci-robot @rluders @openshift-bot @tisnik @openshift-merge-robot