-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1887778: Adds ContainerRuntimeConfig gatherer #216
Bug 1887778: Adds ContainerRuntimeConfig gatherer #216
Conversation
@0sewa0: This pull request references Bugzilla bug 1887778, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Verified on my cluster. @0sewa0 can you please check if it works on 4.3 (and or 4.4)? I guess we should explicitly add the new apiGroups to |
@tremes Tried it on 4.4 and it worked without issue. |
@0sewa0 OK thanks. Interesting....I tried it on 4.3 and it works as well. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0sewa0, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@0sewa0: All pull requests linked via external trackers have merged: Bugzilla bug 1887778 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
My cluster didn't have one by default so here is an example you can use to verify: