Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more verbosity to the tests #237

Merged
merged 1 commit into from Oct 26, 2020

Conversation

quarckster
Copy link
Contributor

At the moment test logs are not so informative:

secret/support created
go test ./test/integration -run ^\(TestIsIOHealthy\)$ ^\(TestPullSecretExists\)$ -timeout 1m
ok  	github.com/openshift/insights-operator/test/integration	0.754s
go test ./test/integration -timeout 13m 
ok  	github.com/openshift/insights-operator/test/integration	676.211s

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-insights-operator-master-insights-operator-e2e-tests-periodic/1320515607073918976/artifacts/insights-operator-e2e-tests-periodic/container-logs/test.log

It would be nice to have more details.

@psimovec
Copy link
Member

/lgtm
thanks!
funny is that I did exactly this just locally before ~30 mins, didn't think about doing PR for this

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psimovec, quarckster

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8d459a9 into openshift:master Oct 26, 2020
@quarckster quarckster deleted the verbose_tests branch October 26, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants