[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer #238

0sewa0 · 2020-10-26T15:10:48Z

A backport (4.6) of a new data enhancement for gathering of ContainerRuntimeConfigs.
My cluster didn't have one by default so here is an example you can use to verify:

apiVersion: machineconfiguration.openshift.io/v1
kind: ContainerRuntimeConfig
metadata:
 name: set-log-and-pid
spec:
 machineConfigPoolSelector:
   matchLabels:
     debug-crio: config-log-and-pid
 containerRuntimeConfig:
   pidsLimit: 2048
   logLevel: debug

Sample archive

docs/insights-archive-sample/config/containerruntimeconfigs/set-log-and-pid.json

Documentation

docs/gathered-data.md

Unit Tests

pkg/gather/clusterconfig/clusterconfig_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

References

https://issues.redhat.com/browse/CCXDEV-3318
https://issues.redhat.com/browse/INSIGHTOCP-84
https://bugzilla.redhat.com/show_bug.cgi?id=1891544

openshift-ci-robot · 2020-10-26T15:10:56Z

@0sewa0: This pull request references Bugzilla bug 1891544, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1887778 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1887778 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes · 2020-10-29T14:09:24Z

Verified.
/lgtm

tremes · 2020-10-30T07:07:30Z

/lgtm

sdodson · 2020-11-09T15:59:41Z

(Patch Manager) This PR was reviewed for inclusion last week, however this adds feature work during the weeks immediately after release where we're focused on stability, upgrade success, and anything which blocks backports of critical customer impacting bugs. Since this doesn't meet those criteria it was not accepted this week and likely will not until we've been able to promote the 4.5 to 4.6 upgrade to the stable channel.

sferich888 · 2020-11-20T12:40:43Z

@sdodson if PX approves backports like, this would that help unstick this PR's current state?

openshift-ci-robot · 2020-12-09T10:39:17Z

@0sewa0: This pull request references Bugzilla bug 1891544, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1887778 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1887778 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-09T11:02:13Z

@0sewa0: This pull request references Bugzilla bug 1891544, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1887778 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1887778 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-12-09T16:45:01Z

/bugzilla refresh

openshift-ci-robot · 2020-12-09T16:45:06Z

@sdodson: This pull request references Bugzilla bug 1891544, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1887778 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1887778 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0sewa0 · 2021-01-28T10:03:25Z

/retest

0sewa0 · 2021-01-28T10:42:32Z

/retest

tremes · 2021-01-28T11:19:27Z

I've verified this again since it was some time ago. I created the ContainerRuntimeConfig above and it was gathered correctly in my cluster.
/lgtm

0sewa0 · 2021-01-28T11:58:13Z

/retest

0sewa0 · 2021-01-28T12:25:01Z

/retest

0sewa0 · 2021-01-28T14:00:24Z

/retest

openshift-bot · 2021-01-28T14:11:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-28T14:24:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T01:00:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T01:13:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T01:26:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T02:05:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T02:44:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T03:10:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T03:23:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T04:28:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T04:54:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T05:07:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T07:04:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T07:17:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T07:43:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

0sewa0 · 2021-01-29T08:43:00Z

@sdodson
The change was just a rebase.
The unfortunate thing that every time a data enhancement backport gets merged it will very likely cause a conflict with every other data enhancement backport(on the same version), this is obviously because that every thing is concentrated in ~2-3 files.
This issue was resolved in 4.7 due to a major refactor.

tremes · 2021-01-29T08:59:51Z

/lgtm

0sewa0 · 2021-01-29T09:26:58Z

/retest

openshift-bot · 2021-01-29T10:45:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

natiiix

/lgtm
(this has already been tested before, but needs a new lgtm label due to rebase)

openshift-ci-robot · 2021-01-29T11:37:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [0sewa0,natiiix,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-02-11T18:17:42Z

@0sewa0: All pull requests linked via external trackers have merged:

openshift/insights-operator#238

Bugzilla bug 1891544 has been moved to the MODIFIED state.

In response to this:

[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 26, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 26, 2020

openshift-ci-robot requested review from derekwaynecarr and rluders October 26, 2020 15:11

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020

openshift-ci-robot assigned tremes Oct 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020

openshift-ci-robot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 9, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 9, 2020

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021

0sewa0 force-pushed the 4.6_ContainerRuntimeConfig branch from f96877d to 1c4fdbe Compare January 28, 2021 08:34

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

0sewa0 force-pushed the 4.6_ContainerRuntimeConfig branch from 1c4fdbe to 779857c Compare January 29, 2021 08:58

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021

Adds ContainerRuntimeConfig gatherer

84537a0

0sewa0 force-pushed the 4.6_ContainerRuntimeConfig branch from 779857c to 84537a0 Compare January 29, 2021 11:25

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021

natiiix approved these changes Jan 29, 2021

View reviewed changes

openshift-ci-robot assigned natiiix Jan 29, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 11, 2021

openshift-merge-robot merged commit 11456e7 into openshift:release-4.6 Feb 11, 2021

[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer #238

[release 4.6] Bug 1891544: Adds ContainerRuntimeConfig gatherer #238

Conversation

0sewa0 commented Oct 26, 2020 • edited

Categories

Sample archive

Documentation

Unit Tests

Privacy

References

openshift-ci-robot commented Oct 26, 2020

tremes commented Oct 29, 2020 • edited

tremes commented Oct 30, 2020

sdodson commented Nov 9, 2020

sferich888 commented Nov 20, 2020

openshift-ci-robot commented Dec 9, 2020

openshift-ci-robot commented Dec 9, 2020

sdodson commented Dec 9, 2020

openshift-ci-robot commented Dec 9, 2020

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

tremes commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

0sewa0 commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 28, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

0sewa0 commented Jan 29, 2021

tremes commented Jan 29, 2021

0sewa0 commented Jan 29, 2021

openshift-bot commented Jan 29, 2021

natiiix left a comment • edited

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 29, 2021

openshift-ci-robot commented Feb 11, 2021

0sewa0 commented Oct 26, 2020 •

edited

tremes commented Oct 29, 2020 •

edited

natiiix left a comment •

edited