New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diskrecorder simplify the Summary function #255
Diskrecorder simplify the Summary function #255
Conversation
Skipping CI for Draft Pull Request. |
Looks pretty nice, so far. It makes sense to me. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rluders, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This is just an idea how to simplify diskrecorder.go. I believe we don't want to merge existing tar files together and most importantly, there is nothing to merge IMO, because the length of merged slice (https://github.com/openshift/insights-operator/blob/master/pkg/record/diskrecorder/diskrecorder.go#L293) will always be 0 or 1 (due to https://github.com/openshift/insights-operator/blob/master/pkg/record/diskrecorder/diskrecorder.go#L301-L307 note the slice is initialized in the for loop) if I am not mistaken.