Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1907378: Gather netnamespaces network info #297

Merged
merged 1 commit into from Dec 15, 2020

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Dec 14, 2020

This is a new data enhancement for gathering interesting networking info about netnamespaces.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • Adding docs/insights-archive-sample/config/netnamespaces.json

Documentation

  • docs/gathered-data.md updated

Unit Tests

  • Added pkg/gather/clusterconfig/netnamespaces_test.go

Privacy

The obfuscation of IP addresses and hostnames will be adressed with https://issues.redhat.com/browse/CCXDEV-3655. It's still being discussed.

References

https://bugzilla.redhat.com/show_bug.cgi?id=1907378

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1907378, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907378: Gather netnamespaces network info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@tremes
Copy link
Contributor Author

tremes commented Dec 14, 2020

/retest

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Dec 14, 2020

/retest

@0sewa0
Copy link
Contributor

0sewa0 commented Dec 15, 2020

/lgtm

tested it using cluster-bot, netnamespaces.json was created without issue

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 50d63c9 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1907378 has been moved to the MODIFIED state.

In response to this:

Bug 1907378: Gather netnamespaces network info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes deleted the netnamespace branch September 14, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants