Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 4.7] Bug 1913343: Added changelog file #300

Merged

Conversation

Serhii1011010
Copy link
Contributor

@Serhii1011010 Serhii1011010 commented Dec 18, 2020

Added a changelog file not including minor changes and changes before October 27.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

No changes

Documentation

No changes

Unit Tests

No new unit tests

Privacy

Not necessary

References

https://issues.redhat.com/browse/CCXDEV-3621
https://bugzilla.redhat.com/show_bug.cgi?id=1913343
https://access.redhat.com/solutions/???

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@rluders
Copy link
Contributor

rluders commented Dec 23, 2020

I think that it is fine, but don't we want to autogenerate this CHANGELOG file? We could get this information from the PR template.

@Serhii1011010
Copy link
Contributor Author

@rluders, I think not all the changes should be in changelog file, but only sufficient ones. We probably need to discuss that after holidays :)

@tremes
Copy link
Contributor

tremes commented Jan 5, 2021

It should be CHANGELOG.md and would be nice to have similar formatting (with links) as in https://github.com/openshift/cluster-monitoring-operator/blob/master/CHANGELOG.md. I would also add more for 4.6 ( at least Adds gatherer for PodDisruptionBudget)

@tremes
Copy link
Contributor

tremes commented Jan 6, 2021

@rluders is there some way how to autogenerate it? I agree with Sergey that we don't want everything in the changelog, but maybe it would be still possible to generate it somehow.

@rluders
Copy link
Contributor

rluders commented Jan 6, 2021

@tremes yep. It is possible to autogenete the changelog. I guess that we could even put some rules to WHAT should be included. Let me check it.

@tremes
Copy link
Contributor

tremes commented Jan 6, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sergey1011010,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@Serhii1011010
Copy link
Contributor Author

/retest

@Serhii1011010 Serhii1011010 changed the title Added changelog file [release 4.7] Bug 1913343: Added changelog file Jan 6, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1913343, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release 4.7] Bug 1913343: Added changelog file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2021
@Serhii1011010
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1913343, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Serhii1011010
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1913343, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Serhii1011010
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1913343, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit db61d28 into openshift:master Jan 6, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: All pull requests linked via external trackers have merged:

Bugzilla bug 1913343 has been moved to the MODIFIED state.

In response to this:

[release 4.7] Bug 1913343: Added changelog file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants