[release-4.7] Bug 1950926: Extend OLM data with CSV display name

[tremes]

This updates the OLM operator gatherer to include corresponding ClusterServiceVersion display name. This is required for the nomination listed below. This PR also updates the gatherer to better handle the errors and extends the corresponding unit test.

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample archive

Sample data updated in:

• docs/insights-archive-sample/config/olm_operators.json

Documentation

No documentation updated

Unit Tests

Test updated and extended in:

• pkg/gather/clusterconfig/olm_operators_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

https://bugzilla.redhat.com/show_bug.cgi?id=1950926
https://issues.redhat.com/browse/INSIGHTOCP-280

[openshift-ci-robot]

@tremes: This pull request references Bugzilla bug 1950926, which is invalid:

• expected dependent Bugzilla bug 1949990 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1950926: Extend OLM data with CSV display name (#400)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

/bugzilla refresh

[openshift-ci-robot]

@tremes: This pull request references Bugzilla bug 1950926, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.z) matches configured target release for branch (4.7.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1949990 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 1949990 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
• bug has dependents

Requesting review from QA contact:
/cc @psimovec

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[0sewa0]

/lgtm

tested it on a cluster-bot cluster, installed some olm operators and got:

[
    {
        "name": "advanced-cluster-management.open-cluster-management",
        "displayName": "Advanced Cluster Management for Kubernetes",
        "version": "v2.2.2",
        "csv_conditions": [
            {
                "lastTransitionTime": "2021-04-20T08:01:07Z",
                "lastUpdateTime": "2021-04-20T08:01:07Z",
                "message": "requirements not yet checked",
                "phase": "Pending",
                "reason": "RequirementsUnknown"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:07Z",
                "lastUpdateTime": "2021-04-20T08:01:08Z",
                "message": "one or more requirements couldn't be found",
                "phase": "Pending",
                "reason": "RequirementsNotMet"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:19Z",
                "lastUpdateTime": "2021-04-20T08:01:19Z",
                "message": "all requirements found, attempting install",
                "phase": "InstallReady",
                "reason": "AllRequirementsMet"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:24Z",
                "lastUpdateTime": "2021-04-20T08:01:24Z",
                "message": "waiting for install components to report healthy",
                "phase": "Installing",
                "reason": "InstallSucceeded"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:24Z",
                "lastUpdateTime": "2021-04-20T08:01:28Z",
                "message": "installing: waiting for deployment multiclusterhub-operator to become ready: Waiting for rollout to finish: 0 of 1 updated replicas are available...\n",
                "phase": "Installing",
                "reason": "InstallWaiting"
            },
            {
                "lastTransitionTime": "2021-04-20T08:02:57Z",
                "lastUpdateTime": "2021-04-20T08:02:57Z",
                "message": "install strategy completed with no errors",
                "phase": "Succeeded",
                "reason": "InstallSucceeded"
            }
        ]
    },
    {
        "name": "anaconda-team-edition.openshift-operators",
        "displayName": "Anaconda Team Edition",
        "version": "v6.1.3",
        "csv_conditions": [
            {
                "lastTransitionTime": "2021-04-20T08:01:33Z",
                "lastUpdateTime": "2021-04-20T08:01:33Z",
                "message": "requirements not yet checked",
                "phase": "Pending",
                "reason": "RequirementsUnknown"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:33Z",
                "lastUpdateTime": "2021-04-20T08:01:33Z",
                "message": "all requirements found, attempting install",
                "phase": "InstallReady",
                "reason": "AllRequirementsMet"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:34Z",
                "lastUpdateTime": "2021-04-20T08:01:34Z",
                "message": "waiting for install components to report healthy",
                "phase": "Installing",
                "reason": "InstallSucceeded"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:34Z",
                "lastUpdateTime": "2021-04-20T08:01:35Z",
                "message": "installing: waiting for deployment anaconda-team-edition to become ready: Waiting for rollout to finish: 0 out of 1 new replicas have been updated...\n",
                "phase": "Installing",
                "reason": "InstallWaiting"
            },
            {
                "lastTransitionTime": "2021-04-20T08:01:58Z",
                "lastUpdateTime": "2021-04-20T08:01:58Z",
                "message": "install strategy completed with no errors",
                "phase": "Succeeded",
                "reason": "InstallSucceeded"
            }
        ]
    }
]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [0sewa0,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@tremes: All pull requests linked via external trackers have merged:

• openshift/insights-operator#402

Bugzilla bug 1950926 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1950926: Extend OLM data with CSV display name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.