[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents #410

rluders · 2021-04-26T12:21:15Z

This PR backports two changes related to GatherClusterOperators #355 and #397.

This backports some changes that allow the gather to collect also logs from pods that are related to unhealthy operators, and also improves the gather responsibility by splitting it into to gathers GatherClusterOperators and GatherClusterOperatorsPodAndEvents.

Sample archive

N/A

Documentation

docs/gathered-data.md (updated)

Unit Tests

pkg/gather/clusterconfig/operators_pods_and_events_test.go (new)
pkg/gather/clusterconfig/operators_test.go (updated)

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

N/A

References

https://issues.redhat.com/browse/CCXDEV-4429
https://bugzilla.redhat.com/show_bug.cgi?id=1953579

…penshift#397) * Split operators gather This splits the cluster operators gather into two gathers, one for operator resources and other for unhealty operators. * Adds precommit target This adds the precommit target to the makefile, so we can execute it to test the stashed changes before actually commit. * Move CompactedEvent This move the structure that was previously defined on operators to operators_unhealthy. * Change operators name This changes the previous operator_unhealty to operator_pods_and_events. * Update gathered documentation This updates the gatherer documentation for operators and operators_pods_and_events

openshift-ci-robot · 2021-04-26T12:21:16Z

@rluders: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release 4.7] Bug : GatherClusterOperators and GatherClusterOperatorsPodAndEvents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-26T12:21:29Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2021-04-26T12:26:27Z

@rluders: This pull request references Bugzilla bug 1953579, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1924663 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1924663 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @psimovec

In response to this:

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-26T12:27:13Z

@rluders: This pull request references Bugzilla bug 1953579, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1924663 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1924663 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

Requesting review from QA contact:
/cc @psimovec

In response to this:

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders · 2021-04-26T12:28:33Z

docs/gathered-data.md

@@ -436,6 +421,18 @@ Relevant Kubernetes API docs:
 Location in archive: config/pod/{namespace}/{pod-name}.json


+## SAPVsystemIptablesLogs


BTW, I notice that this documentation was missing, so... I generate it again, and... here we have it.

docs/gathered-data.md

This fixes the operators_pods_and_events documentation.

tremes · 2021-04-27T08:16:36Z

I tested this locally and was checking the gathered data. Code changes looks fine too. Thanks.
/lgtm

openshift-ci-robot · 2021-04-27T08:16:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rluders,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-06T18:55:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-06T19:06:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-06T21:31:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-06T21:43:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-06T22:42:29Z

@rluders: All pull requests linked via external trackers have merged:

openshift/insights-operator#410

Bugzilla bug 1953579 has been moved to the MODIFIED state.

In response to this:

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2021

openshift-ci-robot requested review from natiiix and psimovec April 26, 2021 12:21

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021

rluders changed the title ~~[release 4.7] Bug : GatherClusterOperators and GatherClusterOperatorsPodAndEvents~~ [release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents Apr 26, 2021

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 26, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 26, 2021

rluders commented Apr 26, 2021

View reviewed changes

rluders marked this pull request as ready for review April 26, 2021 12:30

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2021

tremes reviewed Apr 26, 2021

View reviewed changes

docs/gathered-data.md Outdated Show resolved Hide resolved

Fixes docs

e37c0a3

This fixes the operators_pods_and_events documentation.

rluders requested a review from tremes April 26, 2021 13:00

openshift-ci-robot assigned tremes Apr 27, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021

knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2021

openshift-merge-robot merged commit b0817c9 into openshift:release-4.7 May 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents #410

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents #410

rluders commented Apr 26, 2021 •

edited

Loading

openshift-ci-robot commented Apr 26, 2021

openshift-ci-robot commented Apr 26, 2021

openshift-ci-robot commented Apr 26, 2021

openshift-ci-robot commented Apr 26, 2021

rluders Apr 26, 2021

tremes commented Apr 27, 2021

openshift-ci-robot commented Apr 27, 2021

openshift-bot commented May 6, 2021

openshift-bot commented May 6, 2021

openshift-bot commented May 6, 2021

openshift-bot commented May 6, 2021

openshift-ci bot commented May 6, 2021

		@@ -436,6 +421,18 @@ Relevant Kubernetes API docs:
		Location in archive: config/pod/{namespace}/{pod-name}.json


		## SAPVsystemIptablesLogs

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents #410

[release 4.7] Bug 1953579: GatherClusterOperators and GatherClusterOperatorsPodAndEvents #410

Conversation

rluders commented Apr 26, 2021 • edited Loading

Categories

Sample archive

Documentation

Unit Tests

Privacy

Changelog

References

openshift-ci-robot commented Apr 26, 2021

openshift-ci-robot commented Apr 26, 2021

openshift-ci-robot commented Apr 26, 2021

openshift-ci-robot commented Apr 26, 2021

rluders Apr 26, 2021

Choose a reason for hiding this comment

tremes commented Apr 27, 2021

openshift-ci-robot commented Apr 27, 2021

openshift-bot commented May 6, 2021

openshift-bot commented May 6, 2021

openshift-bot commented May 6, 2021

openshift-bot commented May 6, 2021

openshift-ci bot commented May 6, 2021

rluders commented Apr 26, 2021 •

edited

Loading