Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1959650: Gather SDI-related MachineConfigs #422

Merged
merged 7 commits into from May 18, 2021
Merged

Bug 1959650: Gather SDI-related MachineConfigs #422

merged 7 commits into from May 18, 2021

Conversation

natiiix
Copy link
Contributor

@natiiix natiiix commented May 10, 2021 •
edited

This PR implements an enhancement gathering two MachineConfigs related to the SAP Data Intelligence workload. This enhancement will not be backported past v4.8.

Description from Jira:

After discussions with a SAP team representative, it was determined that two MachineConfigs should be gathered from clusters running SDI. There are also relevant MachineConfigPools, which are already gathered by past data enhancements.

The first MC is called 75-worker-sap-data-intelligence, but on clusters schedulable master nodes, it may also appear as 75-master-sap-data-intelligence.

The second MC is more complicated because it is generated from other resources. It is called 99-sdi-generated-containerruntime on the testing cluster, but its name may be different on other clusters. Instead of being filtered by name, the gatherer should look for a sdi-pids-limit owner reference.

Implementation note: Most SAP-related enhancements first check for the datahubs resource to check if the cluster is running an SDI payload and collect nothing if the resource is not present on the cluster. In the case of this enhancement, this check is intentionally omitted because there should be no way for any of the gathering conditions to be met on a non-SDI cluster and the MachineConfigs are a part of core configuration, which could be present even if the datahubs resource was missing.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • docs/insights-archive-sample/config/machineconfigs/75-worker-sap-data-intelligence.json
  • docs/insights-archive-sample/config/machineconfigs/99-sdi-generated-containerruntime.json

Documentation

  • docs/gathered-data.md - SAPMachineConfigs section

Unit Tests

  • pkg/gather/clusterconfig/sap_machine_configs_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

After a discussion with a SAP team representative, it was determined that the selected MachineConfigs should not contain any sensitive information under normal circumstances.

Changelog

No.

References

Jira Task: https://issues.redhat.com/browse/CCXDEV-4829
Bugzilla Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1959650

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@natiiix natiiix changed the title Gather SDI-related MachineConfigs WIP: Gather SDI-related MachineConfigs May 10, 2021
@natiiix natiiix changed the title WIP: Gather SDI-related MachineConfigs Bug 1959650: Gather SDI-related MachineConfigs May 12, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 12, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

@natiiix: This pull request references Bugzilla bug 1959650, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1959650: Gather SDI-related MachineConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from psimovec May 12, 2021 02:44
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2021

@natiiix: This pull request references Bugzilla bug 1959650, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1959650: Gather SDI-related MachineConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@natiiix natiiix marked this pull request as ready for review May 12, 2021 03:17
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2021
@natiiix
Copy link
Contributor Author

natiiix commented May 13, 2021

/retest

@0sewa0
Copy link
Contributor

0sewa0 commented May 18, 2021

unfortunately I don't have a SAP cluster so I can't really test it, but I went through the code and run the extensive unittest for this change and everything works as expected.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, natiiix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b4c4f14 into openshift:master May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

@natiiix: All pull requests linked via external trackers have merged:

Bugzilla bug 1959650 has been moved to the MODIFIED state.

In response to this:

Bug 1959650: Gather SDI-related MachineConfigs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@tremes tremes Awaiting requested review from tremes

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@0sewa0 0sewa0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@natiiix @0sewa0 @openshift-bot @openshift-merge-robot