Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797563: added TestUnreachableHost #65

Merged
merged 4 commits into from Feb 3, 2020
Merged

Bug 1797563: added TestUnreachableHost #65

merged 4 commits into from Feb 3, 2020

Conversation

lina-is-here
Copy link

added test to verify insights operator reports degraded after 5 unsuccessful upload attempts

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2020
tisnik
tisnik reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good in overall + please look at @iNecas comments as well

test/integration/bugs_test.go Outdated Show resolved Hide resolved
test/integration/main_test.go Outdated Show resolved Hide resolved
test/integration/bugs_test.go Outdated Show resolved Hide resolved
test/integration/main_test.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2020
@lina-is-here
Copy link
Author

I implemented the suggestions but pretty sure it will fail in the CI. I will work on it a bit later.

@lina-is-here
Copy link
Author

/retest

@lina-is-here
Copy link
Author

/retest

1 similar comment
@lina-is-here
Copy link
Author

/retest

tisnik
tisnik approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lina-nikiforova

test/integration/main_test.go
func isOperatorDisabled(t *testing.T, operator *configv1.ClusterOperator) bool {
statusConditions := operator.Status.Conditions

for _, condition := range statusConditions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be refactored as the code is almost the same as in isOperatorDegraded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but ok for tests :)

@tisnik
Copy link
Contributor

tisnik commented Jan 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lina-nikiforova, tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@lina-is-here
Copy link
Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@lina-nikiforova: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lina-is-here lina-is-here changed the title added TestUnreachableHost Bug 1797563: added TestUnreachableHost Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@lina-nikiforova: This pull request references Bugzilla bug 1797563, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1797563: added TestUnreachableHost

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lina-is-here
Copy link
Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@lina-nikiforova: This pull request references Bugzilla bug 1797563, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 5e9ed4d into openshift:master Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@lina-nikiforova: All pull requests linked via external trackers have merged. Bugzilla bug 1797563 has been moved to the MODIFIED state.

In response to this:

Bug 1797563: added TestUnreachableHost

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNecas iNecas iNecas left review comments

@tisnik tisnik tisnik approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@tisnik tisnik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lina-is-here @tisnik @openshift-ci-robot @iNecas @openshift-merge-robot