-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-1502: Update PNCC gatherer #679
Conversation
/test e2e-agnostic-upgrade |
@tremes: This pull request references Jira Issue OCPBUGS-1502, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tremes: This pull request references Jira Issue OCPBUGS-1502, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@tremes: This pull request references Jira Issue OCPBUGS-1502, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rluders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It basically just replaces the client and limit the gathered data to the last 24h.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rluders, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
1 similar comment
/retest |
@tremes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@tremes: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1502 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the
podnetworkconnectivitychecks
gatherer. The gatherer used to get all the PNCCs in the cluster and then read them into memory (see here).It seems there can really be a lot of PNCCs resources in a cluster and it also probably doesn't make much sense to store all of them (in the archive), because then we can have a very old ones included. This limits the failed or outage PNCCsto only those started within last 24h.
Categories
Sample Archive
Documentation
path/to/documentation.md
Unit Tests
path/to/file_test.go
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/OCPBUGS-1502
https://access.redhat.com/solutions/???