Implement periodic gathering as a job in tech preview #787
Conversation
openshift-ci
bot
added
the
approved
|
@tremes: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tremes: trigger 0 job(s) for the /payload-(job|aggregate) command |
|
/payload-job periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-aws-ovn-arm64-techpreview |
|
@tremes: trigger 0 job(s) for the /payload-(job|aggregate) command |
1 similar comment
|
@tremes: trigger 0 job(s) for the /payload-(job|aggregate) command |
|
/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview |
|
@DennisPeriquet: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/63a82bc0-ffe6-11ed-8a6a-1f1592a5945d-0 |
|
/test e2e-gcp-ovn-techpreview |
1 similar comment
|
/test e2e-gcp-ovn-techpreview |
|
/retest |
|
/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview |
|
@tremes: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/51e00d40-03a1-11ee-9c9b-32826c43919b-0 |
There was a problem hiding this comment.
/lgtm
Although there are couple of places like gather_commands Gather function and operator Run function which contain high complexity (and more than 100 lines), I didn't find any dead-end.
Maybe it would be a good idea to revisit this later and try to refactor some parts and include some unit tests to them (currently seems impossible)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @ncaak. Yes you're right. There's a follow-up prepared for the https://issues.redhat.com/browse/CCXDEV-10590 and it will hopefully refactor few things. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview |
|
@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c391050-0917-11ee-8ef7-f4567af4c5ab-0 |
|
/test e2e-gcp-ovn-techpreview |
* Run gathering as separate Pod in tech preview * Move downloading of reports to operator part & propagate Insights Request ID * Minor updates * DataGather CR - very first commit * create a new DataGather CR and prune periodically * read and apply gatherers config from the new CR * Fix anonymizer * do not duplicate gatherer status creation * extract the job responsibility and fix contexts * Copy Gatherer status & tests * diskrecorder_test - narrow down the testing archive path * Fix error reporting in periodic.go * reorder manifest creation experiment * status reporter must be always started for now * rebase
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@tremes We are concerned about the e2e-gcp-ovn-techpreview failing job. Can we confirm if this is not an issue for merging the PR? |
|
Hi @deepsm007, I realized that our current testsuite will not pass with this tech preview upgrade. So when I am looking at the last https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_insights-operator/787/pull-ci-openshift-insights-operator-master-e2e-gcp-ovn-techpreview/1669219468393320448 then I think the failures are expected. Thanks and sorry for this inconvenience. The |
|
/label jira/valid-bug |
openshift-ci
bot
added
the
jira/valid-bug
|
/test ci/prow/e2e-agnostic-upgrade |
|
@tremes: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-agnostic-upgrade |
|
/test e2e |
|
@tremes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/test e2e |
…openshift#787)" (openshift#798)" This reverts commit cd80172.
* Implement periodic gathering as a job in tech preview (openshift#764) * Run gathering as separate Pod in tech preview * Move downloading of reports to operator part & propagate Insights Request ID * Minor updates * DataGather CR - very first commit * create a new DataGather CR and prune periodically * read and apply gatherers config from the new CR * Fix anonymizer * do not duplicate gatherer status creation * extract the job responsibility and fix contexts * Copy Gatherer status & tests * diskrecorder_test - narrow down the testing archive path * Fix error reporting in periodic.go * reorder manifest creation experiment * status reporter must be always started for now * rebase * add resource requests to the new job * rebase * pass linting * rebase
…ift#787)" (openshift#798) This reverts commit bb72dd0.
…penshift#799) * Revert "Revert "Implement periodic gathering as a job in tech preview (openshift#787)" (openshift#798)" This reverts commit cd80172. * add priorityClass to the new Pods
This reopen of #764 with adding resource requests. Please check the description of the original PR.
Categories
Sample Archive
no new data
Documentation
path/to/documentation.mdUnit Tests
path/to/file_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
Yes/No
References
https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???