Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement periodic gathering as a job in tech preview & latest fix #799

Merged
merged 2 commits into from Jun 27, 2023

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jun 23, 2023

This is a unrevert PR with fix for the missing priorityClassName
Please see the original PR #764

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

  • path/to/documentation.md

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from rhrmo and rluders June 23, 2023 07:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@tremes
Copy link
Contributor Author

tremes commented Jun 23, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2023

@tremes: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0dbf1880-1199-11ee-9dd1-2de892c4e959-0

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2023

@tremes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview 1cbb402 link false /test e2e-gcp-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tremes
Copy link
Contributor Author

tremes commented Jun 23, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-sdn-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2023

@tremes: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b620b160-11b6-11ee-8929-07a0341d24b4-0

@tremes
Copy link
Contributor Author

tremes commented Jun 26, 2023

/test e2e-agnostic-upgrade

@@ -66,7 +66,7 @@ linters:
enable:
- bodyclose
- deadcode
- depguard
#- depguard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm already cleaning it up at #776, but I guess its fine. I'll have to rebase it anyway.

@rluders
Copy link
Contributor

rluders commented Jun 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 11a2ad7 and 2 for PR HEAD 1cbb402 in total

@openshift-merge-robot openshift-merge-robot merged commit 8f64a40 into openshift:master Jun 27, 2023
8 of 9 checks passed
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
…penshift#799)

* Revert "Revert "Implement periodic gathering as a job in tech preview (openshift#787)" (openshift#798)"

This reverts commit cd80172.

* add priorityClass to the new Pods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants