Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Build steps in README reflect unnecessary steps #3422

Closed
realnedsanders opened this issue Apr 7, 2020 · 2 comments
Closed

Comments

@realnedsanders
Copy link

Version

$ openshift-install version

refs/heads/master @ b5bbde6
Tue Apr 7 14:39:58 UTC 2020

Platform:

UPI

What happened?

Build steps in README suggest cloning the repository to $GOPATH/src/github.com/openshift/installer.
This is unnecessary as of Go 1.13 due to go modules.

What you expected to happen?

Builld steps in README suggest cloning the repository to an arbitrary path of the user's choice.

realnedsanders pushed a commit to realnedsanders/installer that referenced this issue Apr 7, 2020
Fix documentation to no longer reflect needless requirement of cloning
the installer repository to a directory in $GOPATH/src.

[issue openshift#3422]

* Tags: kind/documentation platform/none size/XS
@abhinavdahiya
Copy link
Contributor

fixed by #3423
/close

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Closing this issue.

In response to this:

fixed by #3423
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs pushed a commit to vrutkovs/installer that referenced this issue Apr 13, 2020
Fix documentation to no longer reflect needless requirement of cloning
the installer repository to a directory in $GOPATH/src.

[issue openshift#3422]

* Tags: kind/documentation platform/none size/XS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants