New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README): README build steps don't require clone to GOPATH #3423
Conversation
Fix documentation to no longer reflect needless requirement of cloning the installer repository to a directory in $GOPATH/src. [issue openshift#3422] * Tags: kind/documentation platform/none size/XS
I didn't think this deserved its own branch, however I can move it if need be. |
Hi @angelofdeauth. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1.13 still allows users to turn off the go modules AFAIK.. so i'm not sure if we can remove this yet? |
That's correct, via the env var
As |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@angelofdeauth: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fix documentation to no longer reflect needless requirement of cloning
the installer repository to a directory in $GOPATH/src.
[issue #3422]