Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): README build steps don't require clone to GOPATH #3423

Merged
merged 1 commit into from Apr 8, 2020

Conversation

realnedsanders
Copy link

Fix documentation to no longer reflect needless requirement of cloning
the installer repository to a directory in $GOPATH/src.

[issue #3422]

  • Tags: kind/documentation platform/none size/XS

Fix documentation to no longer reflect needless requirement of cloning
the installer repository to a directory in $GOPATH/src.

[issue openshift#3422]

* Tags: kind/documentation platform/none size/XS
@realnedsanders
Copy link
Author

I didn't think this deserved its own branch, however I can move it if need be.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @angelofdeauth. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

1.13 still allows users to turn off the go modules AFAIK.. so i'm not sure if we can remove this yet?

@realnedsanders
Copy link
Author

1.13 still allows users to turn off the go modules AFAIK.. so i'm not sure if we can remove this yet?

That's correct, via the env var GO111MODULE=[on|off|auto].
The current minimum version of Go required by the installer is Go 1.13.
According to the go 1.13 modules documentation, the default setting for this variable is auto.
The documentation details auto's behavior as follows:

GO111MODULE=auto enables module-mode if any go.mod is found, even inside GOPATH. (Prior to Go 1.13, GO111MODULE=auto would never enable module-mode inside GOPATH).

As GO111MODULE=off would be a user-specific configuration which differs from the default, I would argue it would be incumbent upon the user to be mindful of their environment-specific configuration.

@abhinavdahiya
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

@angelofdeauth: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt c9f8f4e link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants