Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Use openstack as a cloud name for our credentials #1153

Merged
merged 1 commit into from
Jan 31, 2019
Merged

openstack: Use openstack as a cloud name for our credentials #1153

merged 1 commit into from
Jan 31, 2019

Conversation

flaper87
Copy link
Contributor

We're choosing to hardcode these two values to make the environment more predictable. We expect there to a secret named openstack-credentials and a cloud named openstack in the clouds file stored in this secret.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@flaper87 flaper87 force-pushed the internal-openstack-cloud-name branch 2 times, most recently from 9c7feb5 to a31d353 Compare January 30, 2019 16:09
@flaper87
Copy link
Contributor Author

/test images
/test e2e-aws

@flaper87
Copy link
Contributor Author

/test e2e-aws

@flaper87
Copy link
Contributor Author

flaper87 commented Jan 31, 2019 •
edited

This and #1099 got me to a full, unattended, deployment:

NAME                  STATUS    ROLES     AGE       VERSION
ostest-master-0       Ready     master    87m       v1.11.0+459b2d5
ostest-master-1       Ready     master    87m       v1.11.0+459b2d5
ostest-master-2       Ready     master    87m       v1.11.0+459b2d5
ostest-worker-2884f   Ready     worker    35m       v1.11.0+459b2d5
ostest-worker-p5m92   Ready     worker    34m       v1.11.0+459b2d5
ostest-worker-qq6r2   Ready     worker    33m       v1.11.0+459b2d5

@tomassedovic
Copy link
Contributor

/lgtm

This is a bugfix.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@flaper87
Copy link
Contributor Author

no idea why this hasn't been merged. I'll try to re-trigger the event

/approve
/lgtm

@openshift-ci-robot
Copy link
Contributor

@flaper87: you cannot LGTM your own PR.

In response to this:

no idea why this hasn't been merged. I'll try to re-trigger the event

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tomassedovic
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@flaper87
Copy link
Contributor Author

/lgtm

@openshift-ci-robot
Copy link
Contributor

@flaper87: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, russellb, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [flaper87,russellb,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6921175 into openshift:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@hardys hardys Awaiting requested review from hardys

Assignees

@tomassedovic tomassedovic

@russellb russellb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flaper87 @tomassedovic @openshift-ci-robot @russellb @openshift-merge-robot