-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openstack: fix the openstack creds secret name #1099
openstack: fix the openstack creds secret name #1099
Conversation
/hold |
looks good! Thanks! Let's wait for the freeze to be over |
/test e2e-aws |
/hold cancel |
3b74d78
to
be14196
Compare
We've changed the What do you think? |
/test images |
/test e2e-aws |
be14196
to
155614f
Compare
@@ -81,7 +81,7 @@ func provider(clusterID, clusterName string, platform *openstack.Platform, mpool | |||
},*/ | |||
Image: osImage, | |||
CloudName: platform.Cloud, | |||
CloudsSecret: &corev1.SecretReference{Name: cloudsSecret}, | |||
CloudsSecret: &corev1.SecretReference{Name: cloudsSecret, Namespace: "kube-system"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: What do you think about putting kube-system
in a const
just like cloudSecret
?
155614f
to
8e1beb5
Compare
8e1beb5
to
e3a6c91
Compare
/lgtm |
The OpenStack MachineSets expect `cloudsSecret` to be called `openstack-credentials`, but the one we were creating was called `openstack-creds`. And we must set the `kube-system` namespace, otherwise the Actuator won't be able to find the secret.
e3a6c91
to
a9d730b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The OpenStack MachineSets expect
cloudsSecret
to be calledopenstack-credentials
, but the one we were creating was calledopenstack-creds
.