Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack: switch to CoreDNS #1186

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

tomassedovic
Copy link
Contributor

This replaces the dnsmasq container used the OpenStack provider with
CoreDNS. OpenShift already uses CoreDNS so it doesn't make sense to
bring in a different DNS tech to the mix.

This also reads /etc/resolv.conf for upstream DNS rather than
hardcoding OpenStack's internal IP address. And it uses CNAMEs to
provide etcd IPs instead of generating a hosts file.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2019
This replaces the dnsmasq container used the OpenStack provider with
CoreDNS. OpenShift already uses CoreDNS so it doesn't make sense to
bring in a different DNS tech to the mix.

This also reads /etc/resolv.conf for upstream DNS rather than
hardcoding OpenStack's internal IP address. And it uses CNAMEs to
provide etcd IPs instead of generating a hosts file.
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2019
@flaper87
Copy link
Contributor

flaper87 commented Feb 5, 2019

Tested this locally and it does the job great!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@tomassedovic: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack a05975c link /test e2e-openstack
ci/prow/e2e-libvirt a05975c link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 26c31bc into openshift:master Feb 5, 2019
@tomassedovic tomassedovic deleted the coredns branch February 5, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants