-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenStack: switch to CoreDNS #1186
Conversation
This replaces the dnsmasq container used the OpenStack provider with CoreDNS. OpenShift already uses CoreDNS so it doesn't make sense to bring in a different DNS tech to the mix. This also reads /etc/resolv.conf for upstream DNS rather than hardcoding OpenStack's internal IP address. And it uses CNAMEs to provide etcd IPs instead of generating a hosts file.
Tested this locally and it does the job great! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, tomassedovic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@tomassedovic: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This replaces the dnsmasq container used the OpenStack provider with
CoreDNS. OpenShift already uses CoreDNS so it doesn't make sense to
bring in a different DNS tech to the mix.
This also reads /etc/resolv.conf for upstream DNS rather than
hardcoding OpenStack's internal IP address. And it uses CNAMEs to
provide etcd IPs instead of generating a hosts file.