Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootkube: Pass etcd images into MCO bootstrap #1194

Merged
merged 1 commit into from
Feb 7, 2019
Merged

bootkube: Pass etcd images into MCO bootstrap #1194

merged 1 commit into from
Feb 7, 2019

Conversation

cgwalters
Copy link
Member

This was a missed corresponding change after
openshift/machine-config-operator@6f0f3ff
landed.

Ref: openshift/machine-config-operator#367

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2019
@cgwalters cgwalters mentioned this pull request Feb 5, 2019
Closed
abhinavdahiya
abhinavdahiya reviewed Feb 5, 2019
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different compared to other images. It would be nice if we keep the env like others.

@cgwalters
Copy link
Member Author

This is different compared to other images. It would be nice if we keep the env like others.

OK, I reworked it.

/test e2e-aws

@cgwalters
Copy link
Member Author

Ah OK...running with this locally I see on the master:

[root@osiris-master-0 ~]# crictl logs 102c45fdbb236
/bin/sh: line 6: /usr/local/bin/etcd: No such file or directory

cgwalters added a commit to cgwalters/machine-config-operator that referenced this pull request Feb 5, 2019
@cgwalters
templates: Don't hardcode /usr/local/bin for etcd
de0b997 
The image we're trying to switch to has it in `/usr/bin`, let's
just search `$PATH`.

Ref: openshift/installer#1194
@cgwalters cgwalters mentioned this pull request Feb 5, 2019
Merged
@cgwalters
Copy link
Member Author

Depends: openshift/machine-config-operator#384

@openshift-bot
Copy link
Contributor

/retest

@abhinavdahiya
Copy link
Contributor

openshift/machine-config-operator#384 merged

Let's try again

/retest

@cgwalters
Copy link
Member Author

openshift/machine-config-operator#384 merged

Yeah but it's not in an update payload yet AIUI - last accepted one was ~7 hours ago: https://origin-release.svc.ci.openshift.org/

(I think installer pulls latest accepted right?)

@wking
Copy link
Member

wking commented Feb 6, 2019

I think installer pulls latest accepted right?

Master builds default to latest accepted, but CI is latest master images (regardless of promotion gating).

@cgwalters
Copy link
Member Author

Master builds default to latest accepted, but CI is latest master images (regardless of promotion gating).

Oh god the matrix of combinations I need to understand just expanded...

@abhinavdahiya
Copy link
Contributor

from e2e-aws

level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.bootstrap.aws_s3_bucket.ignition: 1 error occurred:"
level=error msg="\t* aws_s3_bucket.ignition: Error creating S3 bucket: TooManyBuckets: You have attempted to create more buckets than allowed"
level=error msg="\tstatus code: 400, request id: C0118BD0E3019AFE, host id: ykgc+MQizNapIl4gb3lnfWH89zNlDT7q0t8L5r+eFAFy+yxDL5e35BKHE2YpEmynR++Ar9DnTDs="

feels like need to wait for sometime before we retest

@cgwalters
Copy link
Member Author

/test e2e-aws

@cgwalters
Copy link
Member Author

Can this get approved+lgtm so it merges when tests start passing?

@abhinavdahiya
Copy link
Contributor

Can this get approved+lgtm so it merges when tests start passing?

It would be nice if can try this patch locally and paste that here to make sure this works..

that's why i was trying to wait for atleast one successful ci run...

@cgwalters
Copy link
Member Author

cgwalters commented Feb 6, 2019 •
edited

In that last run though the machine-config operator was fine:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1194/pull-ci-openshift-installer-master-e2e-aws/3474/artifacts/e2e-aws/clusteroperators.json

Specifically:

                 {
                        "lastTransitionTime": "2019-02-06T22:09:05Z",
                        "status": "False",
                        "type": "Failing"
                    }

We just died due to storage test flakes AFAICS.

@abhinavdahiya
Copy link
Contributor

In that last run though the machine-config operator was fine:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1194/pull-ci-openshift-installer-master-e2e-aws/3474/artifacts/e2e-aws/clusteroperators.json

Specifically:

                 {
                        "lastTransitionTime": "2019-02-06T22:09:05Z",
                        "status": "False",
                        "type": "Failing"
                    }

We just died due to storage test flakes AFAICS.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@abhinavdahiya
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2019 •
edited

@cgwalters: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 658402b link /test e2e-openstack
ci/prow/e2e-libvirt 658402b link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0ce38cc into openshift:master Feb 7, 2019
@wking
Copy link
Member

wking commented Feb 7, 2019

I've filed openshift/etcd#3 to lay the groundwork for replacing our current, hard-coded etcdctl image with this one pulled from the update payload. That would obsolete my currently-in-flight #1060.

@wking wking mentioned this pull request Feb 7, 2019
Closed
@cgwalters cgwalters mentioned this pull request Feb 8, 2019
Closed
@cgwalters cgwalters mentioned this pull request Feb 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@flaper87 flaper87 Awaiting requested review from flaper87

@hardys hardys Awaiting requested review from hardys

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cgwalters @openshift-bot @abhinavdahiya @wking @openshift-ci-robot @openshift-merge-robot