templates: Don't hardcode /usr/local/bin for etcd #384
Conversation
The image we're trying to switch to has it in `/usr/bin`, let's just search `$PATH`. Ref: openshift/installer#1194
|
/lgtm |
|
/lgtm |
|
@ashcrow: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest |
|
☁️☁️☁️ |
|
/refresh |
|
/approve |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
just wondering and brainstorming, we can take this on Slack if you want, but how do we make sure we don't regress on similar drifts (openshift/installer#1194)? is this on the installer or on mco? how's the installer testing changes in the MCO (or does it use the latest published images)? do we need to start having a job which runs the latest available installer with the very latest mco code to make sure we don't drift? and viceversa? (spending my morning figuring this out also) |
|
(Can people add approve and lgtm here? Prow missed it earlier)
That's what e2e-aws does; it runs master installer against the code from the PR. What we need to do is start gating on degraded: #383 The original PR here sailed right through because we didn't have that. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ashcrow, cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
The image we're trying to switch to has it in
/usr/bin, let'sjust search
$PATH.Ref: openshift/installer#1194