openstack: Security groups update #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaper87
force-pushed
the
sec-groups-update
branch
from
757f027
to
cbd42bd
Compare
openshift-ci-robot
added
size/XXL
data/data/openstack/main.tf
Outdated
| @@ -28,7 +32,7 @@ module "service" { | |||
|
|
|||
| swift_container = "${openstack_objectstorage_container_v1.container.name}" | |||
| cluster_id = "${var.cluster_id}" | |||
| cluster_domain = "${var.cluster_domain}" | |||
flaper87
force-pushed
the
sec-groups-update
branch
from
cbd42bd
to
4be3041
Compare
openshift-ci-robot
added
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, trown The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
pushed a commit
to wking/openshift-installer
that referenced
this pull request
Mar 5, 2019
openstack: Security groups update
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Mar 5, 2019
Through c8b3b55 (Merge pull request openshift#1338 from flaper87/sec-groups-update, 2019-05-01). I've left 8d0847c (openstack: Support setting network UUID via terraform variable, 2018-12-05, openshift#794) undocumented, since it seems like an unstable-enough user-facing API approach that I don't think we want to noise it about and deal with the fall-out when we change the API ;). That commit also made it into this history via 44a9cd3 (openshift#1294). https://github.com/openshift/cluster-version-operator/blob/master/Dockerfile#L8
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Mar 5, 2019
Through c8b3b55 (Merge pull request openshift#1338 from flaper87/sec-groups-update, 2019-05-01). I've left 8d0847c (openstack: Support setting network UUID via terraform variable, 2018-12-05, openshift#794) undocumented, since it seems like an unstable-enough user-facing API approach that I don't think we want to noise it about and deal with the fall-out when we change the API ;). That commit also made it into this history via 44a9cd3 (openshift#1294). I've also left off eecf496 (openstack: remove neutron dns, 2019-02-19, openshift#1294), because I have no idea what that's about ;). I'll fill in an entry for it later once one of the OpenStack devs explains it to me :p.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've changed the way security groups are filtered in the actuator. This patch updates the machine definition.