Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/build: Pin to quay.io/openshift-release-dev/ocp-release:4.0.0-0.8 #1463

Closed
wants to merge 3 commits into from
Closed

hack/build: Pin to quay.io/openshift-release-dev/ocp-release:4.0.0-0.8 #1463

wants to merge 3 commits into from

Conversation

wking
Copy link
Member

@wking wking commented Mar 26, 2019

/hold
This is just for CI, like #1370

@smarterclayton pushed registry.svc.ci.openshift.org/ocp/release:4.0.0-0.nightly-2019-03-23-183709 to quay.io/openshift-release-dev/ocp-release:4.0.0-0.8.

The release-image change-log was generated using the generator from openshift/origin#22030 and:

$ oc adm release info --changelog ~/.local/lib/go/src --changes-from quay.io/openshift-release-dev/ocp-release:4.0.0-0.7 quay.io/openshift-release-dev/ocp-release:4.0.0-0.8

CC @abhinavdahiya

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 26, 2019
@wking wking force-pushed the version-0.15.0-pins branch 3 times, most recently from 98f1308 to d087923 Compare March 26, 2019 04:20
@wking
CHANGELOG: Document changes since 0.14.0
acafa4f 
Through 0d891e1 (Merge pull request openshift#1446 from staebler/vsphere_tf,
2019-03-21).
@wking
docs/design/resource_dep: Rebuild with KubeSystemConfigmapEtcdCA, etc.
bb38714 
Catching up with 53c6fc3 (assets/manifests: push etcd configmaps
and secrets into cluster, 2019-03-04, openshift#1363).  Generated with:

  $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:

  $ dot -V
  dot - graphviz version 2.30.1 (20170916.1124)
@wking
hack/build: Pin to quay.io/openshift-release-dev/ocp-release:4.0.0-0.8
462d548 
Clayton pushed
registry.svc.ci.openshift.org/ocp/release:4.0.0-0.nightly-2019-03-23-183709
to quay.io/openshift-release-dev/ocp-release:4.0.0-0.8.

Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing
of the pinned release despite openshift/release@60007df2 (Use
RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03,
openshift/release#1793).

I'd initially expected to export the pinning environment variables in
release.sh, but I've put them in build.sh here because our continuous
integration tests use build.sh directly and don't go through
release.sh.

The release-image change-log was generated using the generator from
[1] and:

  $ oc adm release info --changelog ~/.local/lib/go/src --changes-from quay.io/openshift-release-dev/ocp-release:4.0.0-0.7 quay.io/openshift-release-dev/ocp-release:4.0.0-0.8

[1]: openshift/origin#22030
@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/shellcheck 462d548 link /test shellcheck
ci/prow/tf-fmt 462d548 link /test tf-fmt
ci/prow/tf-lint 462d548 link /test tf-lint
ci/prow/yaml-lint 462d548 link /test yaml-lint
ci/prow/unit 462d548 link /test unit
ci/prow/govet 462d548 link /test govet
ci/prow/e2e-aws 462d548 link /test e2e-aws
ci/prow/images 462d548 link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Mar 26, 2019

Conflict, so CI will never pass, and this is v0.15.0 now anyway.

@wking wking closed this Mar 26, 2019
@wking wking deleted the version-0.15.0-pins branch March 26, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@steveej steveej Awaiting requested review from steveej

Assignees

@crawford crawford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wking @openshift-ci-robot @crawford