Modify kubeadmin usage message, admins should not use kubeadmin via CLI #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
sallyom
force-pushed
the
modify-kubeadmin-msg
branch
2 times, most recently
from
5d10ae2
to
0d1b956
Compare
wking
reviewed
Apr 1, 2019
cmd/openshift-install/create.go
Outdated
| @@ -427,8 +427,8 @@ func logComplete(directory, consoleURL string) error { | |||
| return err | |||
| } | |||
| logrus.Info("Install complete!") | |||
| logrus.Infof("Run 'export KUBECONFIG=%s' to manage the cluster with 'oc', the OpenShift CLI.", kubeconfig) | |||
| logrus.Infof("The cluster is ready when 'oc login -u kubeadmin -p %s' succeeds (wait a few minutes).", pw) | |||
| logrus.Infof("To access the cluster as the system:admin user, run 'export KUBECONFIG=%s'", kubeconfig) | |||
There was a problem hiding this comment.
I think you want to mention oc in this line. Maybe:
logrus.Infof("To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=%s'", kubeconfig)There was a problem hiding this comment.
looks good! thanks, updated
wking
reviewed
Apr 1, 2019
cmd/openshift-install/create.go
Outdated
| logrus.Infof("Run 'export KUBECONFIG=%s' to manage the cluster with 'oc', the OpenShift CLI.", kubeconfig) | ||
| logrus.Infof("The cluster is ready when 'oc login -u kubeadmin -p %s' succeeds (wait a few minutes).", pw) | ||
| logrus.Infof("To access the cluster as the system:admin user, run 'export KUBECONFIG=%s'", kubeconfig) | ||
| logrus.Info("Manage the cluster with 'oc', the OpenShift CLI. Run 'oc --help' for the menu.") |
There was a problem hiding this comment.
Do we want this level of detail? If folks need to be reminded about --help, I'd much rather be linking them to external docs for using oc (or hope they say "huh, dunno what oc is. Ah, this next line is talking about a web console, that sounds like my style").
There was a problem hiding this comment.
lol yup, good point.
wking
reviewed
Apr 1, 2019
sallyom
force-pushed
the
modify-kubeadmin-msg
branch
from
0d1b956
to
35f75ad
Compare
sallyom
force-pushed
the
modify-kubeadmin-msg
branch
from
35f75ad
to
80e637e
Compare
openshift-ci-robot
added
size/S
|
@wking, updated w/ the other 2 files, thanks |
The kubeadmin user should only be used to temporarily access the console, and only until an admin configures a proper Identity Provider. There is no reason to login as the kubeadmin user via CLI. If oauth is broken in a cluster, an admin can still access via CLI as system:admin, but will not be able to access via kube:admin.
sallyom
force-pushed
the
modify-kubeadmin-msg
branch
from
80e637e
to
dee6929
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Apr 5, 2019
This was added in 4033577 (Append router CA to cluster CA in kubeconfig, 2019-02-12, openshift#1242), where the motivation was [1]: With users created with an identity-provider, OAuth flow goes through router and router-ca is not trusted. This prohibits the user from using oc login from command line, without manually appending the router ca to the cluster ca. The openshift-ingress-operator creates the router-CA and this is not available until the very end of an install. This PR adds the router CA from configmap router-ca -n openshift-config-managed to the kubeconfig certificate-authority-data. This allows an identity-provided user to oc login from the terminal. But the admin kubeconfig is already authenticated, so folks shouldn't be using 'oc login' with that kubeconfig. For example, see dee6929 (Modify kubeadmin usage message, admins should not use kubeadmin via CLI, 2019-04-01, openshift#1513). That leaves us with no use case for this modification, and making the finish code watch-only sets us up to rename away from the user-provided-infrastructure subcommand. [1]: openshift#1242 (comment)
This was referenced Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubeadmin user should only be used to temporarily access the
console, and only until an admin configures a proper Identity Provider.
There is no reason to login as the kubeadmin user via CLI. If oauth
is broken in a cluster, an admin can still access via CLI as system:admin,
but will not be able to access via kube:admin.
@enj https://jira.coreos.com/browse/AUTH-293