Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/dns/route53: Tag the tectonic zone #158

Closed
wants to merge 1 commit into from
Closed

modules/dns/route53: Tag the tectonic zone #158

wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Aug 21, 2018

We've been tagging our internal zone since 75fb49a (coreos/tectonic-installer#465). Tagging this resource makes it easier to cleanup resource leaks, because the resource is more obviously associated with the given cluster (and you can use extra_tags to set expirationDate, etc.).

@wking
modules/dns/route53: Tag the tectonic zone
3a263c8 
We've been tagging our internal zone since 75fb49a (platforms/aws:
apply tags to internal route53 zone, 2017-05-02,
coreos/tectonic-installer#465).  Tagging this resource makes it easier
to cleanup resource leaks, because the resource is more obviously
associated with the given cluster (and you can use extra_tags to set
expirationDate, etc.).
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2018
@wking
Copy link
Member Author

wking commented Aug 21, 2018

The e2e-aws error was:

Error refreshing state: 1 error(s) occurred:

* module.dns.data.aws_route53_zone.tectonic: 1 error(s) occurred:

* module.dns.data.aws_route53_zone.tectonic: data.aws_route53_zone.tectonic: no matching Route53Zone found

Maybe I accidentally removed a shared zone during my orphan-resource pruning? It doesn't look like we're providing our own zone.

@wking
Copy link
Member Author

wking commented Aug 21, 2018

Checking if the "no matching Route53Zone" error is reproducible:

/retest

@openshift-ci-robot
Copy link
Contributor

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 3a263c8 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Aug 21, 2018

Checking if the "no matching Route53Zone" error is reproducible

It is.

@wking
Copy link
Member Author

wking commented Aug 21, 2018

Checking if the "no matching Route53Zone" error is reproducible

It is.

Because I'm touching a data block here, not a resource block. 🤦‍♂️

@wking wking closed this Aug 21, 2018
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
@flaper87
Get user-data/startupScripts from secrets (openshift#173)
973889f 
This commit adds the ability to pass custom userData/startupScripts to
the machines using kubernetes secrets. The previous workflow that used
the machine-setup ConfigMap has been removed in favor of the new one.

Fixes openshift#158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wking @openshift-ci-robot