-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 1696342: pkg/asset: include kubeadmin password in the IgnitionConfig target #1592
BUG 1696342: pkg/asset: include kubeadmin password in the IgnitionConfig target #1592
Conversation
$ /bin/openshift-install --dir dev-metal-0 create ignition-configs
INFO Consuming "Install Config" from target directory
$ tree dev-metal-0
dev-metal-0
├── auth
│ ├── kubeadmin-password
│ └── kubeconfig
├── bootstrap.ign
├── master.ign
├── metadata.json
└── worker.ign
1 directory, 6 files |
/lgtm |
/refresh |
/skip |
Hmm, the ci-bot seems to be stuck... |
BZ#1696342 [1] pointed out that installer was not providing the kubeadmin secret when running the `create ignition-configs` target. That target is currently the primary means to perform UPI type installations. Missing kubeadmin password file cause error like `FATAL open /root/installation/baremetal-0404/auth/kubeadmin-password: no such file or directory` when running the wait-for command. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1696342
753b026
to
15f2aa2
Compare
New changes are detected. LGTM label has been removed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhinavdahiya: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
BZ#1696342 1 pointed out that installer was not providing the kubeadmin secret when running the
create ignition-configs
target. That target is currently the primarymeans to perform UPI type installations. Missing kubeadmin password file cause error like
FATAL open /root/installation/baremetal-0404/auth/kubeadmin-password: no such file or directory
when running the wait-for command.
/cc @wking @staebler