Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 1696342: pkg/asset: include kubeadmin password in the IgnitionConfig target #1592

Merged

Conversation

abhinavdahiya
Copy link
Contributor

BZ#1696342 1 pointed out that installer was not providing the kubeadmin secret when running the create ignition-configs target. That target is currently the primary
means to perform UPI type installations. Missing kubeadmin password file cause error like FATAL open /root/installation/baremetal-0404/auth/kubeadmin-password: no such file or directory
when running the wait-for command.

/cc @wking @staebler

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 10, 2019
@abhinavdahiya
Copy link
Contributor Author

$ /bin/openshift-install --dir dev-metal-0 create ignition-configs
INFO Consuming "Install Config" from target directory
$ tree dev-metal-0
dev-metal-0
├── auth
│   ├── kubeadmin-password
│   └── kubeconfig
├── bootstrap.ign
├── master.ign
├── metadata.json
└── worker.ign

1 directory, 6 files

@staebler
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@abhinavdahiya
Copy link
Contributor Author

/refresh

@abhinavdahiya
Copy link
Contributor Author

/skip

@abhinavdahiya
Copy link
Contributor Author

Hmm, the ci-bot seems to be stuck...

BZ#1696342 [1] pointed out that installer was not providing the kubeadmin secret when running the `create ignition-configs` target. That target is currently the primary
means to perform UPI type installations. Missing kubeadmin password file cause error like `FATAL open /root/installation/baremetal-0404/auth/kubeadmin-password: no such file or directory`
when running the wait-for command.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1696342
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@abhinavdahiya abhinavdahiya added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@staebler
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 15f2aa2 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants