pkg/destroy/aws: Stop skipping direct network-interface deletion #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd added this to save on AWS API-call volume in fc70eb2 (pkg/destroy/aws: Skip direct tag deletion for network interfaces, 2019-05-02, openshift#1704). But now that we support user-provided VPCs with installer-provided network interfaces, it's no longer feasible. Happily, the tagged network interfaces are just for installer-created control-plane machines, see 4fcdc1c (data/aws: explicitly create the network interface for masters to speed up DNS, 2019-03-04, openshift#1361). And since cf69c1e (pkg/destroy/aws: Terminate instances before other resources, 2019-08-06, openshift#2169) we are terminating instances first and waiting for their termination to complete before proceeding to other resources. So we should no longer have the long runs of failed network-interface deletion attempts while we wait for the instances to terminate, and this commit should make our removal more robust without increasing our API-call volume.
openshift-ci-robot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd added this to save on AWS API-call volume in fc70eb2 (#1704). But now that we support user-provided VPCs with installer-provided network interfaces, it's no longer feasible. Happily, the tagged network interfaces are just for installer-created control-plane machines, see 4fcdc1c (#1361). And since cf69c1e (#2169) we are terminating instances first and waiting for their termination to complete before proceeding to other resources. So we should no longer have the long runs of failed network-interface deletion attempts while we wait for the instances to terminate, and this commit should make our removal more robust without increasing our API-call volume.