Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP internal load balancers to use custom-provided networks. #2520

Merged

Conversation

patrickdillon
Copy link
Contributor

The creation of internal load balancers was not taking into account custom-provided networks. This was causing failure on BYO VPC installs with the error:

ERROR                                              
ERROR Error: Error creating ForwardingRule: googleapi: Error 400: Invalid value for field 'resource.backendService': 'https://www.googleapis.com/compute/v1/projects/openshift-dev-installer/regions/us-east4/backendServices/pd-6bk9x-api-internal'. Forwarding rule network projects/openshift-dev-installer/global/networks/default must be the same as backend service network projects/openshift-dev-installer/global/networks/byovpc-network., invalid 
ERROR                                              
ERROR   on ../../../../../../../../tmp/openshift-install-913030725/network/lb-private.tf line 34, in resource "google_compute_forwarding_rule" "api_internal": 
ERROR   34: resource "google_compute_forwarding_rule" "api_internal" { 
ERROR                                              
ERROR                                              
FATAL failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply using Terraform 

Updated references to master subnet as well.

The creation of internal load balancers was not taking into account custom-provided networks. This was causing failure on BYO VPC installs with the error:
 Forwarding rule network projects/openshift-dev-installer/global/networks/default must be the same as backend service network projects/openshift-dev-installer/global/networks/byovpc-network., invalid

Updated references to master subnet as well.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2019
@patrickdillon
Copy link
Contributor Author

local testing on a byo vpc cluster is working so far.
/test e2e-gcp

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 3a87653 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 3a87653 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bda2d72 into openshift:master Oct 17, 2019
@patrickdillon patrickdillon deleted the gcp-ilb-byo-vpc branch October 24, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants