Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libvirt: start using os.UserCacheDir to find the cache folder #2578

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Libvirt: start using os.UserCacheDir to find the cache folder #2578

merged 1 commit into from
Oct 28, 2019

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Oct 28, 2019

Installer was upgraded to golang 1.12, so we can start using this function.

@Fedosin
Libvirt: start using os.UserCacheDir to find the cache folder
f51b187 
Installer was upgraded to golang 1.12, so we can start using this
function.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2019
@Fedosin
Copy link
Contributor Author

Fedosin commented Oct 28, 2019

/test govet

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@Fedosin
Copy link
Contributor Author

Fedosin commented Oct 28, 2019

/test e2e-aws-upgrade

1 similar comment
@abhinavdahiya
Copy link
Contributor

/test e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 28, 2019 •
edited
Loading

@Fedosin: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 f51b187 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin
Copy link
Contributor Author

Fedosin commented Oct 28, 2019

/test e2e-aws-upgrade

@openshift-merge-robot openshift-merge-robot merged commit 3a12c82 into openshift:master Oct 28, 2019
@Fedosin Fedosin deleted the libvirt_cache branch November 1, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fedosin @abhinavdahiya @openshift-ci-robot @openshift-merge-robot