Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1762618: pkg/asset/ignition: bootstrap kubeconfig to use api-int #2647

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

jstuever
Copy link
Contributor

@jstuever jstuever commented Nov 8, 2019

Prior to this change, the default kubeconfig on the bootstrap host used
the external api url. This caused issues when the external api was not
available such as when proxy is configured but the noProxy list does not
contain the external api. In such situation, the bootstrap host fails to
report bootstrap complete to the cluster. As a result, the installer
fails during the wait-for bootstrap-complete stage.

This change adds a new kubeconfig (adminInternal) which points to
api-int. The bootstrap host defaults to this new kubeconfig. Api-int
is already in the noProxy list. As a result, the bootstrap host can
report complete even when the external api is inaccessible.

@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1762618, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1762618: pkg/asset/ignition: bootstrap kubeconfig to use api-int

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2019
Prior to this change, the default kubeconfig on the bootstrap host used
the external api url. This caused issues when the external api was not
available such as when proxy is configured but the noProxy list does not
contain the external api. In such situation, the bootstrap host fails to
report bootstrap complete to the cluster. As a result, the installer
fails during the wait-for bootstrap-complete stage.

This change adds a new kubeconfig (adminInternal) which points to
api-int. The bootstrap host defaults to this new kubeconfig. Api-int
is already in the noProxy list. As a result, the bootstrap host can
report complete even when the external api is inaccessible.
@jstuever
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor

/test e2e-azure

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit a498f63 into openshift:master Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

@jstuever: All pull requests linked via external trackers have merged. Bugzilla bug 1762618 has been moved to the MODIFIED state.

In response to this:

Bug 1762618: pkg/asset/ignition: bootstrap kubeconfig to use api-int

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jstuever: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 2aae2a9 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants