baremetal: configure ironic interfaces for other boot mechanisms #2766
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
These are ironic "interfaces" right? Not network interfaces? If that's right, we might want different names to avoid confusing the two and to avoid exposing too directly the details of ironic through the interfaces in OpenShift. In fact, if we can aggregate these things into some sort of unified thing so a user only has to give us one value for a host that would be even better. |
Yes, these are all Ironic interfaces. This PR was just how I thought metal3-io/baremetal-operator#359 would work. Today, the BMO exposes a "BootInterface" as part of access details which is specific to Ironic, it could be one thing like an Interfaces() function or something. These are all top-level params sent as part of configuring a node in Ironic |
OK, I think I get what you're doing now. The "top level thing" I was talking about is the BMC type, so that's good. For some reason I thought we were going to be asking the user for all of these values, but if they're going to come from the BMC code in the BMO then I think this is fine. |
baremetal-operator's BMC code now handles providers that use virtual
media. Updated using the following command:
dep ensure -update github.com/metal3-io/baremetal-operator
stbenjam
force-pushed
the
virtual-media
branch
from
241e692
to
125e969
Compare
openshift-ci-robot
added
size/L
stbenjam
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
stbenjam
force-pushed
the
virtual-media
branch
from
125e969
to
51ca657
Compare
In order to support additional mechanisms for provisioning machines beyond iPXE, such as Virtual Media, we need to be able to configure various interfaces (boot_interface, power_interface, etc).
stbenjam
force-pushed
the
virtual-media
branch
from
51ca657
to
a0ce5d8
Compare
|
/label platform/baremetal |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1360/ |
|
/assign @abhinavdahiya |
|
/approve |
openshift-ci-robot
added
the
approved
|
lgtm - @dhellmann do you have any remaining comments or are we good to merge this now? |
|
I'm happy with this version. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, dhellmann, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
In order to support additional mechanisms for provisioning machines
beyond iPXE, such as Virtual Media, we need to be able to configure
various interfaces (boot_interface, power_interface, etc). This data comes from baremetal-operator, as baremetal-operator's BMC code now handles providers that use virtual media. Venoring was updated using the following command: