Skip to content

Bug 1781846: baremetal: configure ironic interfaces for other boot mechanisms#2780

Closed
stbenjam wants to merge 2 commits intoopenshift:release-4.3from
stbenjam:virtual-media-4.3
Closed

Bug 1781846: baremetal: configure ironic interfaces for other boot mechanisms#2780
stbenjam wants to merge 2 commits intoopenshift:release-4.3from
stbenjam:virtual-media-4.3

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Dec 10, 2019

This is a cherry-pick of #2766 for 4.3. The vendoring isn't a strict cherry-pick as I've pointed Gopkg.toml to the release-4.3 branch of baremetal-operator to update it.

In order to support additional mechanisms for provisioning machines
beyond iPXE, such as Virtual Media, we need to be able to configure
various interfaces (boot_interface, power_interface, etc). This data comes from baremetal-operator, as baremetal-operator's BMC code now handles providers that use virtual media. Venoring was updated using the following command:

dep ensure -update github.com/metal3-io/baremetal-operator

baremetal-operator's BMC code now handles providers that use virtual
media. Updated using the following command:

    dep ensure -update github.com/metal3-io/baremetal-operator
In order to support additional mechanisms for provisioning machines
beyond iPXE, such as Virtual Media, we need to be able to configure
various interfaces (boot_interface, power_interface, etc).
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 10, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: This pull request references Bugzilla bug 1781846, which is invalid:

  • expected dependent Bugzilla bug 1781845 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1781846: baremetal: configure ironic interfaces for other boot mechanisms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Copy Markdown
Member Author

Will refresh when #2766 lands.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 10, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: This pull request references Bugzilla bug 1781846, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1781846: baremetal: configure ironic interfaces for other boot mechanisms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 11, 2019
@stbenjam
Copy link
Copy Markdown
Member Author

/retest

@stbenjam
Copy link
Copy Markdown
Member Author

/assign @abhinavdahiya

@jomeier
Copy link
Copy Markdown
Contributor

jomeier commented Dec 25, 2019

/retest

Copy link
Copy Markdown
Contributor

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Jan 24, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sdodson: This pull request references Bugzilla bug 1781846, which is invalid:

  • expected dependent Bugzilla bug 1781845 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 24, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Jan 24, 2020

/approve
/lgtm
(on behalf of @jstuever, not sure why his lgtm didn't stick)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Copy Markdown
Member Author

/close

Not required in 4.3.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: Closed this PR.

Details

In response to this:

/close

Not required in 4.3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants