*: Add platform owners #2782
*: Add platform owners #2782
Conversation
`<platform>-approvers` and `<platform>-reviewers` alias from `OWNER_ALIASES` should be used to maintain membership.
This adds various people to platform owners
openshift-ci-robot
added
size/L
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
| baremetal-reviewers: | ||
| - celebdor | ||
| - markmc | ||
| - russellb | ||
| - hardys | ||
| - stbenjam | ||
| aws-approvers: | ||
| - patrickdillon |
There was a problem hiding this comment.
If we drop auto approval we'll need to add a second here so PRs from @patrickdillon aren't blocked.
There was a problem hiding this comment.
well i'm thinking we should use the -approvers as additive to installer-approvers to reduce duplication...
|
/approve |
it is used to find good candidates, and doesn't affect actually who can lgtm. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
Adding platform owners helps increase the people should help reduce bottleneck on
installer-approvers/assign @sdodson
/cc @openshift/openshift-team-installer
/cc @stbenjam @hardys