Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add platform owners #2782

Merged
merged 2 commits into from
Dec 12, 2019
Merged

*: Add platform owners #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73eeef7
*: add OWNERS for all platform specific directories
abhinavdahiya Dec 10, 2019
a5bd365
OWNERS_ALIASES: add aws, gcp, azure platform alias
abhinavdahiya Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ aliases:
- smarterclayton
- wking
installer-reviewers:
- fabianofranz
- jcpowermac
- jhixson74
- jstuever
Expand All @@ -25,13 +26,31 @@ aliases:
- tomassedovic
- iamemilio
- pierreprinetti
openstack-reviewers:
vsphere-approvers:
- abhinavdahiya
- dav1x
- mtnbikenc
- jcpowermac
- staebler
vsphere-reviewers:
baremetal-approvers:
- hardys
- stbenjam
baremetal-reviewers:
- celebdor
- markmc
- russellb
- hardys
- stbenjam
aws-approvers:
- patrickdillon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we drop auto approval we'll need to add a second here so PRs from @patrickdillon aren't blocked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i'm thinking we should use the -approvers as additive to installer-approvers to reduce duplication...

aws-reviewers:
gcp-approvers:
- jstuever
- patrickdillon
gcp-reviewers:
azure-approvers:
- fabianofranz
- jhixson74
azure-reviewers:
7 changes: 7 additions & 0 deletions data/data/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions data/data/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
2 changes: 2 additions & 0 deletions data/data/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions data/data/bootstrap/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions data/data/bootstrap/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions data/data/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions docs/design/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions docs/user/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions docs/user/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
7 changes: 7 additions & 0 deletions docs/user/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/cluster/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/cluster/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
2 changes: 2 additions & 0 deletions pkg/asset/cluster/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/cluster/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/installconfig/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/installconfig/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/installconfig/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/machines/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/machines/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
2 changes: 2 additions & 0 deletions pkg/asset/machines/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/machines/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/manifests/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
7 changes: 7 additions & 0 deletions pkg/asset/manifests/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/destroy/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/destroy/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
2 changes: 2 additions & 0 deletions pkg/destroy/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions pkg/destroy/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/terraform/gather/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/terraform/gather/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
7 changes: 7 additions & 0 deletions pkg/terraform/gather/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/tfvars/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/tfvars/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
2 changes: 2 additions & 0 deletions pkg/tfvars/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions pkg/tfvars/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions pkg/types/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions pkg/types/azure/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- azure-approvers
reviewers:
- azure-reviewers
2 changes: 2 additions & 0 deletions pkg/types/baremetal/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- baremetal-approvers
reviewers:
- baremetal-reviewers
7 changes: 7 additions & 0 deletions pkg/types/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers
7 changes: 7 additions & 0 deletions upi/aws/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aws-approvers
reviewers:
- aws-reviewers
7 changes: 7 additions & 0 deletions upi/gcp/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- gcp-approvers
reviewers:
- gcp-reviewers