Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1782584: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster #2796

Merged
merged 1 commit into from
Dec 12, 2019
Merged

[release-4.3] Bug 1782584: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster #2796

merged 1 commit into from
Dec 12, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2790

/assign abhinavdahiya

@abhinavdahiya
destroy/gcp/policybinding.go: identity deleted service accounts belon…
922f8a7 
…ging to the cluster

Based on https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Binding

The members values can be:
```
deleted:serviceAccount:{emailid}?uid={uniqueid}: An email address (plus unique identifier) representing a service account that has been recently deleted. For example, my-other-app@appspot.gserviceaccount.com?uid=123456789012345678901. If the service account is undeleted, this value reverts to serviceAccount:{emailid} and the undeleted service account retains the role in the binding.
```

this looks like a new addition to the API since the archive from Oct 26, 2019 doesn't have these value type. see https://web.archive.org/web/20181026092140/https://cloud.google.com/resource-manager/reference/rest/Shared.Types/Binding

Also it doesn't look like the API is being consistent with the result as two consecutive requests are returning different responses :P
```
[7:08:11] ➜  installer git:(add_platform_owners) ✗ gcloud projects get-iam-policy openshift-gce-devel-ci --format json | grep "ci-op-4wlm9"

        "serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-m-w75nq@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-w@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-i-nnvgl@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-i-zh522@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-m-w75nq@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-openshift-i-zh522@openshift-gce-devel-ci.iam.gserviceaccount.com",

        "serviceAccount:ci-op-4wlm9-w@openshift-gce-devel-ci.iam.gserviceaccount.com",

[7:08:23] ➜  installer git:(add_platform_owners) ✗ gcloud projects get-iam-policy openshift-gce-devel-ci --format json | grep "ci-op-4wlm9"

        "deleted:serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-m-w75nq@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=115542993089051207368",

        "deleted:serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-w@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=106651455962694555805",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-i-nnvgl@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=113695655870612204124",

        "deleted:serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-i-zh522@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=103715387178859573892",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-m-w75nq@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=115542993089051207368",

        "deleted:serviceAccount:ci-op-4wlm9-m@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=111636284758116941377",

        "deleted:serviceAccount:ci-op-4wlm9-openshift-i-zh522@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=103715387178859573892",

        "deleted:serviceAccount:ci-op-4wlm9-w@openshift-gce-devel-ci.iam.gserviceaccount.com?uid=106651455962694555805",
```
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2019
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782583, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1782583 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1782583: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2019
@abhinavdahiya abhinavdahiya changed the title [release-4.3] Bug 1782583: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster [release-4.3] Bug 1782584: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster Dec 11, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782584, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] Bug 1782584: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

/skip

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@sdodson
Copy link
Member

sdodson commented Dec 11, 2019

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

e2e-gcp-upgrade uses previous installer code to install and upgrade the cluster to new release-image. I uses the previous destroy to cleanup... so it's not a great indicator for this fix.

/test e2e-gcp

to make sure the fix works on this branch.

@abhinavdahiya
Copy link
Contributor

/retest

@sdodson
Copy link
Member

sdodson commented Dec 12, 2019

/refresh

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 922f8a7 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure 922f8a7 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Dec 12, 2019

/override ci/prow/e2e-azure
Unrelated to azure

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure

In response to this:

/override ci/prow/e2e-azure
Unrelated to azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3fe3c06 into openshift:release-4.3 Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1782584 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1782584: destroy/gcp/policybinding.go: identity deleted service accounts belonging to the cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @abhinavdahiya @sdodson @openshift-merge-robot