Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/openstack: Make cli stage overrideable #2850

Merged
merged 1 commit into from Dec 21, 2019

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Dec 19, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2019
@LorbusChris LorbusChris mentioned this pull request Dec 19, 2019
8 tasks
@LorbusChris
Copy link
Member Author

LorbusChris commented Dec 19, 2019

(This is unrelated, I just want to get a second gcp e2e run for comparison)
/test e2e-gcp

@smarterclayton
Copy link
Contributor

This shouldn't be necessary.

@LorbusChris
Copy link
Member Author

@mandre
Copy link
Member

mandre commented Dec 20, 2019

/approve
It's not exactly clear to me how this is supposed to fix the above error (seems like a no-op change to me apart from the image version bump), however it does make the Dockerfile more consistent so 👍

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@LorbusChris LorbusChris changed the title images/openstack: Make cli ref overrideable images/openstack: Make cli stage overrideable Dec 21, 2019
@openshift-ci-robot
Copy link
Contributor

@LorbusChris: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 17e5952 link /test e2e-gcp
ci/prow/e2e-aws-scaleup-rhel7 b3db0ef link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-libvirt b3db0ef link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

Thanks!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4c58ffd into openshift:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants