Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openstack UPI: Deprecate MachineCIDR #2892

Merged
merged 1 commit into from Jan 8, 2020
Merged

Openstack UPI: Deprecate MachineCIDR #2892

merged 1 commit into from Jan 8, 2020

Conversation

pierreprinetti
Copy link
Member

Replace MachineCIDR in UPI documentation with MachineNetwork: []

Ref: #2829

/label platform/openstack
/cc @mandre @iamemilio

@pierreprinetti
Openstack UPI: Deprecate MachineCIDR
b02b050 
Replace MachineCIDR in UPI documentation with MachineNetwork: []

Ref: openshift#2829
@openshift-ci-robot openshift-ci-robot added platform/openstack size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips b02b050 link /test e2e-aws-fips
ci/prow/e2e-aws-scaleup-rhel7 b02b050 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Jan 8, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit b7825c5 into openshift:master Jan 8, 2020
@pierreprinetti pierreprinetti deleted the os_fix_machinecidr branch January 8, 2020 09:03
pierreprinetti added a commit to shiftstack/installer that referenced this pull request Jan 9, 2020
@pierreprinetti
Openstack UPI: machineCIDR machineNetwork.[].cidr
73dec4f 
A previous change referenced the cluster network instead of the machine
network.

ref: openshift#2829
ref: openshift#2892
@pierreprinetti pierreprinetti mentioned this pull request Jan 9, 2020
Merged
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Jan 30, 2020
@pierreprinetti @jhixson74
Openstack UPI: machineCIDR machineNetwork.[].cidr
abdf8cd 
A previous change referenced the cluster network instead of the machine
network.

ref: openshift#2829
ref: openshift#2892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@mandre mandre Awaiting requested review from mandre

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pierreprinetti @openshift-ci-robot @mandre @openshift-merge-robot