Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstack UPI: machineCIDR machineNetwork.[].cidr #2896

Merged

Conversation

pierreprinetti
Copy link
Member

A previous change referenced the cluster network instead of the machine
network.

ref: #2829
ref: #2892

/label platform/openshift
/cc @mandre @iamemilio

A previous change referenced the cluster network instead of the machine
network.

ref: openshift#2829
ref: openshift#2892
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: The label(s) /label platform/openshift cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

A previous change referenced the cluster network instead of the machine
network.

ref: #2829
ref: #2892

/label platform/openshift
/cc @mandre @iamemilio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2020
@pierreprinetti
Copy link
Member Author

/label platform/openstack

@mandre
Copy link
Member

mandre commented Jan 9, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@pierreprinetti
Copy link
Member Author

/retest

3 similar comments
@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2020

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 73dec4f link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Jan 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 500bd80 into openshift:master Jan 10, 2020
@pierreprinetti pierreprinetti deleted the os_fix_machinecidr branch January 10, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants