Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/user/vsphere: Fix "vcenter" -> "vCenter" #2902

Merged
merged 1 commit into from Jan 14, 2020
Merged

docs/user/vsphere: Fix "vcenter" -> "vCenter" #2902

merged 1 commit into from Jan 14, 2020
+2 −2

Conversation

wking
Copy link
Member

@wking wking commented Jan 10, 2020

It's been vCenter since the property landed in 3e73413 (#1591). This commit fixes vcenter typos from 0ec07d0 (#1545) and a947609 (#2162).

@wking
docs/user/vsphere: Fix "vcenter" -> "vCenter"
1b7e598 
It's been vCenter since the property landed in 3e73413
(types/vsphere: simplify vsphere platform, 2019-04-10, openshift#1591).  This
commit fixes "vcenter" typos from 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545) and a947609 (docs/user:
Standardize install-config property documentation, 2019-08-05, openshift#2162).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@wking
Copy link
Member Author

wking commented Jan 10, 2020

to match 3e73413#diff-9fac02c062eb49aa0ba92d2f0003003fR5-R6

@jhixson74
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2020
@jcpowermac
Copy link
Contributor

/approve

1 similar comment
@sdodson
Copy link
Member

sdodson commented Jan 14, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, jhixson74, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6a0eb91 into openshift:master Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 1b7e598 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-fips 1b7e598 link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking deleted the fix-doc-vcenter-yaml-casing branch January 15, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 jhixson74 approved these changes

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

Assignees

@jhixson74 jhixson74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wking @jhixson74 @jcpowermac @sdodson @openshift-ci-robot @openshift-bot @openshift-merge-robot