Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: vSphere installation docs #1545

Merged
merged 1 commit into from
Apr 11, 2019
Merged

docs: vSphere installation docs #1545

merged 1 commit into from
Apr 11, 2019

Conversation

staebler
Copy link
Contributor

@staebler staebler commented Apr 8, 2019

Docs for installing on vSphere.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@staebler staebler changed the title [WIP] docs: vSphere installation docs docs: vSphere installation docs Apr 10, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2019
@abhinavdahiya
Copy link
Contributor

small nits, but largely LGTM 🎆

@staebler
Copy link
Contributor Author

5930b44...facfc53 review feedback addressed

@staebler
docs: vSphere installation docs
0ec07d0 
Docs for installing on vSphere.
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8dae21c into openshift:master Apr 11, 2019
wking added a commit to wking/openshift-installer that referenced this pull request Sep 5, 2019
@wking
docs/user: Bump vSphere and metal from v1beta4 to v1
ef483d6 
Most of our docs were bumped in befde3c (pkg/types/installconfig:
Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references
snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545)
and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
@wking wking mentioned this pull request Sep 5, 2019
Merged
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/vsphere/install_upi: Fix #monitor-for-cluster-completion re…
e6718da 
…ference

Broken since the docs landed in 0ec07d0 (docs: vSphere installation
docs, 2019-04-07, openshift#1545).
@wking wking mentioned this pull request Oct 10, 2019
Merged
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/vsphere/install_upi: Fix [...][#...] references
6fa36d5 
Broken since the docs landed in 0ec07d0 (docs: vSphere installation
docs, 2019-04-07, openshift#1545).
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/vsphere/install_upi: Fix [...][#...] references
0ec6b17 
Broken since the docs landed in 0ec07d0 (docs: vSphere installation
docs, 2019-04-07, openshift#1545).
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/vsphere/install_upi: Fix [...][#...] references
999073a 
Broken since the docs landed in 0ec07d0 (docs: vSphere installation
docs, 2019-04-07, openshift#1545).  Also a bunch of other broken links and some
minor wordsmithing.
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/vsphere/install_upi: Fix [...][#...] references, etc.
679cb7f 
Broken since the docs landed in 0ec07d0 (docs: vSphere installation
docs, 2019-04-07, openshift#1545).  Also a bunch of other broken links and some
minor wordsmithing.
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/(vsphere|metal)/install_upi: Fix [...][#...] references, etc.
d46d6d1 
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545).  Also a bunch of other broken
links and some minor wordsmithing.
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
@wking
docs/user/(vsphere|metal)/install_upi: Fix [...][#...] references, etc.
fdad481 
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545).  Also a bunch of other broken
links and some minor wordsmithing.
alaypatel07 pushed a commit to alaypatel07/installer that referenced this pull request Nov 13, 2019
@wking @alaypatel07
docs/user/(vsphere|metal)/install_upi: Fix [...][#...] references, etc.
87fe240 
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545).  Also a bunch of other broken
links and some minor wordsmithing.
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Dec 6, 2019
@wking @jhixson74
docs/user: Bump vSphere and metal from v1beta4 to v1
67ed9de 
Most of our docs were bumped in befde3c (pkg/types/installconfig:
Bump v1beta4 to v1, 2019-04-10, openshift#1589), but these v1beta4 references
snuck in with 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545)
and 0055065 (baremetal: add baremetal IPI platform, 2019-07-16, openshift#1873).
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Dec 6, 2019
@wking @jhixson74
docs/user/(vsphere|metal)/install_upi: Fix [...][#...] references, etc.
a0c69e7 
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545).  Also a bunch of other broken
links and some minor wordsmithing.
wking added a commit to wking/openshift-installer that referenced this pull request Jan 10, 2020
@wking
docs/user/vsphere: Fix "vcenter" -> "vCenter"
1b7e598 
It's been vCenter since the property landed in 3e73413
(types/vsphere: simplify vsphere platform, 2019-04-10, openshift#1591).  This
commit fixes "vcenter" typos from 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545) and a947609 (docs/user:
Standardize install-config property documentation, 2019-08-05, openshift#2162).
@wking wking mentioned this pull request Jan 10, 2020
Merged
patrickdillon pushed a commit to patrickdillon/installer that referenced this pull request Jan 21, 2020
@wking @patrickdillon
docs/user/vsphere: Fix "vcenter" -> "vCenter"
b300a14 
It's been vCenter since the property landed in 3e73413
(types/vsphere: simplify vsphere platform, 2019-04-10, openshift#1591).  This
commit fixes "vcenter" typos from 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545) and a947609 (docs/user:
Standardize install-config property documentation, 2019-08-05, openshift#2162).
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Jan 30, 2020
@wking @jhixson74
docs/user/vsphere: Fix "vcenter" -> "vCenter"
e42584c 
It's been vCenter since the property landed in 3e73413
(types/vsphere: simplify vsphere platform, 2019-04-10, openshift#1591).  This
commit fixes "vcenter" typos from 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545) and a947609 (docs/user:
Standardize install-config property documentation, 2019-08-05, openshift#2162).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford crawford left review comments

@gpei gpei gpei left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@wking wking Awaiting requested review from wking

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@staebler @abhinavdahiya @openshift-ci-robot @crawford @gpei @openshift-merge-robot