Bug 1791437: asset/manifests: add openshift-install configmap #2929

crawford · 2020-01-15T18:31:52Z

This adds support for generating the openshift-install ConfigMap when
using a UPI installation flow. Before this, the ConfigMap was generated
during the "cluster" target rather than the manifests target, so that we
could distinguish between an IPI and a UPI installation. The user had
the option of overriding the "invoker" field using the environment
variable OPENSHIFT_INSTALL_INVOKER. Even if the environment variable was
used, the ConfigMap would not be present in a UPI installation (because
it wasn't generated in the "manifests" target). This change causes the
installer to generate that ConfigMap in the "manifests" target (in
addition to the "cluster" target) when it sees the environment variable.

We will make use of this functionality in CI, where we specify the job
as the invoker.

crawford · 2020-01-15T18:35:05Z

/test e2e-aws-upi

crawford · 2020-01-15T18:48:46Z

/test e2e-aws-upi

smarterclayton · 2020-01-15T19:59:33Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-01-15T19:59:34Z

@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crawford · 2020-01-15T20:19:32Z

/retittle Bug 1791437: asset/manifests: add openshift-install configmap

crawford · 2020-01-15T20:22:06Z

/test e2e-aws-upi

crawford · 2020-01-15T20:22:35Z

Spelling....
/retitle Bug 1791437: asset/manifests: add openshift-install configmap

openshift-ci-robot · 2020-01-15T20:22:39Z

@crawford: This pull request references Bugzilla bug 1791437, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1791437: asset/manifests: add openshift-install configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crawford · 2020-01-15T20:24:07Z

/bugzilla refresh

openshift-ci-robot · 2020-01-15T20:24:13Z

@crawford: This pull request references Bugzilla bug 1791437, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crawford · 2020-01-15T20:26:33Z

/hold

Let me verify that this actually shows up in telemetry before we merge this.

crawford · 2020-01-15T20:49:23Z

/test e2e-aws-upi

crawford · 2020-01-15T22:22:11Z

/test e2e-aws
/test e2e-aws-upi

crawford · 2020-01-15T22:30:38Z

/retest

crawford · 2020-01-15T23:26:48Z

/retest

crawford · 2020-01-16T00:23:49Z

cluster_installer{invoker=~"openshift-internal-ci/e2e-aws-upi/.*"} shows the cluster. Still waiting on AWS to copy AMIs. We must be bumping up against their internal limits.

crawford · 2020-01-16T01:10:33Z

/test e2e-aws-upgrade

crawford · 2020-01-16T03:56:51Z

cluster_installer{invoker=~"openshift-internal-ci/e2e-aws-upi/.*"} and cluster_installer{invoker=~"openshift-internal-ci/e2e-aws-upgrade/.*"} show the UPI and IPI clusters.

/hold cancel

patrickdillon · 2020-01-21T00:33:48Z

/lgtm

sdodson · 2020-01-24T14:24:13Z

/retest

crawford · 2020-01-24T20:37:57Z

Rebased onto master. I'm running a test locally to figure out what's going on with the AWS IPI installation.

pkg/asset/cluster/tfvars.go

crawford · 2020-01-27T19:51:51Z

/test e2e-aws-upi

crawford · 2020-01-27T22:39:37Z

/test e2e-aws-upi

This adds support for generating the openshift-install ConfigMap when using a UPI installation flow. Before this, the ConfigMap was generated during the "cluster" target rather than the manifests target, so that we could distinguish between an IPI and a UPI installation. The user had the option of overriding the "invoker" field using the environment variable OPENSHIFT_INSTALL_INVOKER. Even if the environment variable was used, the ConfigMap would not be present in a UPI installation (because it wasn't generated in the "manifests" target). This change causes the installer to generate that ConfigMap in the "manifests" target (in addition to the "cluster" target) when it sees the environment variable. We will make use of this functionality in CI, where we specify the job as the invoker.

crawford · 2020-01-27T23:37:20Z

/test e2e-aws-upi

crawford · 2020-01-28T00:51:48Z

I'm not sure what's going on with the UPI tests (there don't appear to be any workers), but the partial cluster that comes up does have the expected ConfigMap:

$ oc get configmap -n openshift-config openshift-install -o yaml
apiVersion: v1
data:
  invoker: openshift-internal-ci/e2e-aws-upi/61
  version: unreleased-master-2431-g3c96f3bd961006b1d1609629fda35eb4af6c819f-dirty
kind: ConfigMap
metadata:
  creationTimestamp: "2020-01-28T00:08:18Z"
  name: openshift-install
  namespace: openshift-config

And both the cluster created by e2e-aws and the manual IPI run I did earlier show up in telemetry.

vrutkovs · 2020-01-28T12:37:04Z

/retest

sdodson · 2020-01-28T14:19:34Z

/lgtm

sdodson · 2020-01-28T15:04:59Z

/hold cancel

crawford · 2020-01-28T16:58:09Z

/retest

crawford · 2020-01-28T23:42:41Z

Let’s see if this works any better, now that we have #3007.

/retest

crawford · 2020-01-29T00:24:28Z

From the scaleup job:

Error: Provider produced inconsistent result after apply

When applying changes to module.bootstrap.aws_s3_bucket.ignition, provider
"aws" produced an unexpected new value for was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.

@abhinavdahiya have we seen this one before? (Yes, https://bugzilla.redhat.com/show_bug.cgi?id=1745196)

crawford · 2020-01-29T03:54:12Z

Quite a smorgasbord of failures.

FIPS bootstrapped but failed to run any tests:

Starting pod/ip-10-0-129-122us-east-2computeinternal-debug ...
To use host binaries, run `chroot /host`

Removing debug pod ...
Error from server (BadRequest): container "container-00" in pod "ip-10-0-129-122us-east-2computeinternal-debug" is waiting to start: ContainerCreating

/retest

openshift-ci-robot · 2020-01-29T05:34:32Z

@crawford: All pull requests linked via external trackers have merged. Bugzilla bug 1791437 has been moved to the MODIFIED state.

In response to this:

Bug 1791437: asset/manifests: add openshift-install configmap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-01-29T05:34:56Z

@smarterclayton: new pull request created: #3010

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-01-29T07:55:03Z

@crawford: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	`27de643`	link	`/test e2e-libvirt`
ci/prow/e2e-aws-scaleup-rhel7	`27de643`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

crawford · 2020-01-30T21:00:39Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-01-30T21:00:54Z

@crawford: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/installer\n ! [rejected] cherry-pick-2929-to-release-4.3 -> cherry-pick-2929-to-release-4.3 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/installer'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crawford · 2020-01-30T21:00:54Z

/cherrypick release-4.3

openshift-cherrypick-robot · 2020-01-30T21:01:01Z

@crawford: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/installer\n ! [rejected] cherry-pick-2929-to-release-4.3 -> cherry-pick-2929-to-release-4.3 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/installer'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2020

openshift-ci-robot requested review from jhixson74 and jstuever January 15, 2020 18:32

openshift-ci-robot changed the title ~~asset/manifests: add openshift-install configmap~~ Bug 1791437: asset/manifests: add openshift-install configmap Jan 15, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 15, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 15, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2020

openshift-ci-robot assigned patrickdillon Jan 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020

vrutkovs reviewed Jan 27, 2020

View reviewed changes

pkg/asset/cluster/tfvars.go Outdated Show resolved Hide resolved

openshift-ci-robot assigned sdodson Jan 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2020

openshift-merge-robot merged commit 850fe40 into openshift:master Jan 29, 2020

openshift-cherrypick-robot mentioned this pull request Jan 29, 2020

[release-4.3] Bug 1791437: asset/manifests: add openshift-install configmap #3010

Closed

crawford deleted the upi-invoker branch January 29, 2020 05:48

crawford mentioned this pull request Jan 31, 2020

Bug 1791440: asset/manifests: add openshift-install configmap #3031

Merged

Bug 1791437: asset/manifests: add openshift-install configmap #2929

Bug 1791437: asset/manifests: add openshift-install configmap #2929

Conversation

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

smarterclayton commented Jan 15, 2020

openshift-cherrypick-robot commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

openshift-ci-robot commented Jan 15, 2020

crawford commented Jan 15, 2020

openshift-ci-robot commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 15, 2020

crawford commented Jan 16, 2020

crawford commented Jan 16, 2020

crawford commented Jan 16, 2020

patrickdillon commented Jan 21, 2020

sdodson commented Jan 24, 2020

crawford commented Jan 24, 2020

crawford commented Jan 27, 2020

crawford commented Jan 27, 2020

crawford commented Jan 27, 2020

crawford commented Jan 28, 2020

vrutkovs commented Jan 28, 2020

sdodson commented Jan 28, 2020

sdodson commented Jan 28, 2020

crawford commented Jan 28, 2020

crawford commented Jan 28, 2020

crawford commented Jan 29, 2020 • edited

crawford commented Jan 29, 2020

openshift-ci-robot commented Jan 29, 2020

openshift-cherrypick-robot commented Jan 29, 2020

openshift-ci-robot commented Jan 29, 2020

crawford commented Jan 30, 2020

openshift-cherrypick-robot commented Jan 30, 2020

crawford commented Jan 30, 2020

openshift-cherrypick-robot commented Jan 30, 2020

crawford commented Jan 29, 2020 •

edited