New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootkube: Update to stable-4.4 channel #2940
bootkube: Update to stable-4.4 channel #2940
Conversation
Make the example slightly simpler on version number to better reflect what a human might see. Noticed this while updating the channel to stable-4.3 - apparently we'd also found and replaced this value before.
Now that we are on 4.4 we need to update the default channel.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
17 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/retest |
1 similar comment
/retest |
/hold cancel |
So that Cincinnati doesn't complain when the console bumps its hard-coded list of channels and starts asking for stable-4.4 ([1] is in flight to remove the need for the console to hard-code available channels, but hasn't seen much recent progress). And even without the console issue, the installer has been putting new clusters in stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift/installer#2940). [1]: openshift/enhancements#123
Like d7fb12c (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift#2940), but for 4.5 (no that release-4.4 is no longer being fast-forwarded to track master).
So that Cincinnati doesn't complain when the console bumps its hard-coded list of channels and starts asking for stable-4.4 ([1] is in flight to remove the need for the console to hard-code available channels, but hasn't seen much recent progress). And even without the console issue, the installer has been putting new clusters in stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift/installer#2940). [1]: openshift/enhancements#123
So that Cincinnati doesn't complain when the console bumps its hard-coded list of channels and starts asking for stable-4.4 ([1] is in flight to remove the need for the console to hard-code available channels, but hasn't seen much recent progress). And even without the console issue, the installer has been putting new clusters in stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift/installer#2940). [1]: openshift/enhancements#123
So that Cincinnati doesn't complain when the console bumps its hard-coded list of channels and starts asking for stable-4.4 ([1] is in flight to remove the need for the console to hard-code available channels, but hasn't seen much recent progress). And even without the console issue, the installer has been putting new clusters in stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift/installer#2940). [1]: openshift/enhancements#123
So that Cincinnati doesn't complain when the console bumps its hard-coded list of channels and starts asking for stable-4.4 ([1] is in flight to remove the need for the console to hard-code available channels, but hasn't seen much recent progress). And even without the console issue, the installer has been putting new clusters in stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift/installer#2940). [1]: openshift/enhancements#123
So that Cincinnati doesn't complain when the console bumps its hard-coded list of channels and starts asking for stable-4.4 ([1] is in flight to remove the need for the console to hard-code available channels, but hasn't seen much recent progress). And even without the console issue, the installer has been putting new clusters in stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift/installer#2940). [1]: openshift/enhancements#123
Now that we are on 4.4 we need to update the default channel.
Make the example slightly simpler on version number to better reflect what
a human might see. Noticed this while updating the channel to stable-4.3 -
apparently we'd also found and replaced this value before.