Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootkube: Update to stable-4.4 channel #2940

Merged
merged 2 commits into from Jan 22, 2020

Conversation

smarterclayton
Copy link
Contributor

Now that we are on 4.4 we need to update the default channel.

Make the example slightly simpler on version number to better reflect what
a human might see. Noticed this while updating the channel to stable-4.3 -
apparently we'd also found and replaced this value before.

Make the example slightly simpler on version number to better
reflect what a human might see. Noticed this while updating the
channel to stable-4.3 - apparently we'd also found and replaced
this value before.
Now that we are on 4.4 we need to update the default channel.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2020
@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@smarterclayton
Copy link
Contributor Author

/retest

@sdodson
Copy link
Member

sdodson commented Jan 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jan 20, 2020

/hold
to stop the hotlooping

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@smarterclayton
Copy link
Contributor Author

/retest

1 similar comment
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit dd770f0 into openshift:master Jan 22, 2020
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 12, 2020
So that Cincinnati doesn't complain when the console bumps its
hard-coded list of channels and starts asking for stable-4.4 ([1] is
in flight to remove the need for the console to hard-code available
channels, but hasn't seen much recent progress).  And even without the
console issue, the installer has been putting new clusters in
stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to
stable-4.4 channel, 2020-01-16, openshift/installer#2940).

[1]: openshift/enhancements#123
wking added a commit to wking/openshift-installer that referenced this pull request Mar 12, 2020
Like d7fb12c (bootkube: Update to stable-4.4 channel, 2020-01-16, openshift#2940),
but for 4.5 (no that release-4.4 is no longer being fast-forwarded to
track master).
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Apr 16, 2020
So that Cincinnati doesn't complain when the console bumps its
hard-coded list of channels and starts asking for stable-4.4 ([1] is
in flight to remove the need for the console to hard-code available
channels, but hasn't seen much recent progress).  And even without the
console issue, the installer has been putting new clusters in
stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to
stable-4.4 channel, 2020-01-16, openshift/installer#2940).

[1]: openshift/enhancements#123
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 14, 2020
So that Cincinnati doesn't complain when the console bumps its
hard-coded list of channels and starts asking for stable-4.4 ([1] is
in flight to remove the need for the console to hard-code available
channels, but hasn't seen much recent progress).  And even without the
console issue, the installer has been putting new clusters in
stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to
stable-4.4 channel, 2020-01-16, openshift/installer#2940).

[1]: openshift/enhancements#123
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 29, 2020
So that Cincinnati doesn't complain when the console bumps its
hard-coded list of channels and starts asking for stable-4.4 ([1] is
in flight to remove the need for the console to hard-code available
channels, but hasn't seen much recent progress).  And even without the
console issue, the installer has been putting new clusters in
stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to
stable-4.4 channel, 2020-01-16, openshift/installer#2940).

[1]: openshift/enhancements#123
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Aug 24, 2020
So that Cincinnati doesn't complain when the console bumps its
hard-coded list of channels and starts asking for stable-4.4 ([1] is
in flight to remove the need for the console to hard-code available
channels, but hasn't seen much recent progress).  And even without the
console issue, the installer has been putting new clusters in
stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to
stable-4.4 channel, 2020-01-16, openshift/installer#2940).

[1]: openshift/enhancements#123
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
So that Cincinnati doesn't complain when the console bumps its
hard-coded list of channels and starts asking for stable-4.4 ([1] is
in flight to remove the need for the console to hard-code available
channels, but hasn't seen much recent progress).  And even without the
console issue, the installer has been putting new clusters in
stable-4.4 since openshift/installer@d7fb12c07a (bootkube: Update to
stable-4.4 channel, 2020-01-16, openshift/installer#2940).

[1]: openshift/enhancements#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants