Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/openshift-install: shift timeouts from api to bootstrap #3005

Merged
merged 1 commit into from Jan 28, 2020

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Jan 28, 2020

cluster-etcd-operator introduces a new workflow for the installer. By having an etcd instance on the bootstrap node we can quickly move to API up.

But currently, the scaling process of etcd is in some circumstances cresting the 30 min timeout. This PR addresses this short term issue by reducing the api timeout to 20 mins and adding that time (10mins) to the bootstrap timeout.

I had a conversation about this with Clayton this is not a permanent change. CEO must reduce install times not increase.

related to: openshift/cluster-etcd-operator#58

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@hexfusion
Copy link
Contributor Author

@abhinavdahiya
Copy link
Contributor

Would love to see some metrics/timeline on what's taking all that time?

@smarterclayton
Copy link
Contributor

/lgtm
/approve

Team has permission to play with timeouts while we stabilize

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Contributor Author

hexfusion commented Jan 28, 2020

Would love to see some metrics/timeline on what's taking all that time?

That is fair @abhinavdahiya mostly we are waiting for default service accounts to be available which we sync to disk and use for init container clients. As we are a static pod we do not have direct access to service account auth like normal pods. We hope to optimize this waiting also, reviewing our sync logic to eliminate any unnecessary waiting.

I will try to get a doc going showing our progress soon with these details.

@openshift-merge-robot openshift-merge-robot merged commit 9f0f119 into openshift:master Jan 28, 2020
@openshift-ci-robot
Copy link
Contributor

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack d2389f6 link /test e2e-openstack
ci/prow/e2e-aws-scaleup-rhel7 d2389f6 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-fips d2389f6 link /test e2e-aws-fips
ci/prow/e2e-libvirt d2389f6 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants