-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootkube.sh.template: Changed command for BOOTSTRAP_IP #3193
Conversation
Hi @tsorya. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
73c85ea
to
7999714
Compare
new command uses "ip route get" to get ip address of default gateway of the node. Fixes openshift#3041 Till now "hostname -I | awk {'print 1'}" was used. The method that gets the first address produced by the hostname -I is unreliable, because (according to the documentation) one cannot make any assumptions about the order of the addresses. On baremetal we have more than one nic and sometimes wrong ip was used. Signed-off-by: Igal Tsoiref <itsoiref@redhat.com>
7999714
to
4e3b950
Compare
I think #3175 obsoletes this PR. |
got it. closing |
@tsorya: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bootkube.sh.template: Changed command for BOOTSTRAP_IP