bug 1805251: Master azure terraform address prefixes #3247
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
jhixson74
force-pushed
the
master_azure_terraform_address_prefixes
branch
from
bf5df2c
to
a849eca
Compare
address_prefixes argument. The virtual network resource allows inline subnets, but does not current support this argument. When the address_prefixes argument is used, address_prefix will be null when terraform refreshes its state causing terraform to panic. This code updates the virtual network resource to allow address_prefixes to be used and for address_prefix to be null. https://bugzilla.redhat.com/show_bug.cgi?id=1808973
jhixson74
force-pushed
the
master_azure_terraform_address_prefixes
branch
from
a849eca
to
3021993
Compare
|
/test e2e-azure |
|
@jhixson74 this PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805936 and https://bugzilla.redhat.com/show_bug.cgi?id=1805251 correct? |
seems to have done well in terms of going past the bootstrap complete. |
Correct. |
jhixson74
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test e2e-azure |
|
/approve |
|
/test e2e-aws-upgrade |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
jhixson74
changed the title
|
@jhixson74: This pull request references Bugzilla bug 1805251, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/test e2e-azure |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jhixson74: All pull requests linked via external trackers have merged. Bugzilla bug 1805251 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jhixson74: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
When a subnet uses address_prefixes, address_prefix is null in the virtual network resource. Add address_prefixes to virtual network resource and allow null for address_prefix. Don't assume IPv4 for private_ip_address on load balancer resource.
https://bugzilla.redhat.com/show_bug.cgi?id=1808973