Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fcos] Merge fcos-devel #3338

Merged
merged 1 commit into from
Mar 27, 2020
Merged

[fcos] Merge fcos-devel #3338

merged 1 commit into from
Mar 27, 2020

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Mar 24, 2020 •
edited
Loading

This branch contains exactly the same code as the LorbusChris:fcos-devel branch
from #3337
but keeps history of the fcos branch intact so CI tests can run.

Fixes okd-project/okd#116

@LorbusChris LorbusChris changed the base branch from master to fcos March 24, 2020 14:22
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2020
@LorbusChris LorbusChris force-pushed the fcos-rebase-merge branch 2 times, most recently from 249b5bd to f873d0b Compare March 24, 2020 19:31
@vrutkovs
Copy link
Member

/retest

@vrutkovs
Copy link
Member

Generally LGTM, but it still has "source: null" in ssh config, so it would break MCO rebase

@LorbusChris
Copy link
Member Author

/cc @vrutkovs

@LorbusChris
Copy link
Member Author

/hold
this contains all changes from current master -- will change that to release-4.4 instead

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@LorbusChris
Copy link
Member Author

actually, no -- the delta with 4.4 is too big (no Go Modules etc)
let's stick to master
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@vrutkovs
Copy link
Member

kube-controller-manager never became ready

/retest

@vrutkovs
Copy link
Member

Cluster operator ingress Available is False with IngressUnavailable: Not all ingress controllers are available

/retest

@LorbusChris
Copy link
Member Author

ingress controller didn't come up
/retest

@vrutkovs
Copy link
Member

Reached the test phase! \o/

openshift-machine-api alert is a bit odd

/retest

@vrutkovs vrutkovs mentioned this pull request Mar 25, 2020
Closed
@vrutkovs
Copy link
Member

/retest

@LorbusChris
Copy link
Member Author

/hold
let's switch to v3 for provided ignition config templates to avoid issues later when upgradin from here (upgrading from v3.1-exp might be troublesome)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@LorbusChris LorbusChris force-pushed the fcos-rebase-merge branch 3 times, most recently from 662139f to 95a9c3c Compare March 26, 2020 16:18
@LorbusChris
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@vrutkovs
Copy link
Member

machine-api alerts, seems worker didn't join the cluster

/retest

@LorbusChris
Copy link
Member Author

/test e2e-vsphere

@LorbusChris
Copy link
Member Author

/test e2e-aws

@LorbusChris
Copy link
Member Author

/test e2e-vsphere

@LorbusChris
Copy link
Member Author

looks like another flake..
/test e2e-vsphere

@LorbusChris
Copy link
Member Author

/test e2e-vsphere

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 27, 2020 •
edited
Loading

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 7138483 link /test e2e-libvirt
ci/prow/e2e-ovirt 7138483 link /test e2e-ovirt
ci/prow/e2e-openstack 7138483 link /test e2e-openstack
ci/prow/e2e-aws-fips 7138483 link /test e2e-aws-fips
ci/prow/e2e-aws-upgrade 7138483 link /test e2e-aws-upgrade
ci/prow/e2e-aws-steps 7138483 link /test e2e-aws-steps
ci/prow/e2e-aws-scaleup-rhel7 7138483 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member

/override ci/prow/e2e-vsphere

vrutkovs
vrutkovs approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

we'll sort out vSphere later - it looks like CI issue

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere

In response to this:

/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4e7126e into openshift:fcos Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@celebdor celebdor Awaiting requested review from celebdor

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LorbusChris @vrutkovs @openshift-ci-robot @openshift-merge-robot